Updates from book 3 complete progression #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollasch
commented
Apr 23, 2024
src/TheRestOfYourLife/pdf.h
Outdated
Comment on lines
3
to
12
| //============================================================================================== | ||
| // Originally written in 2016 by Peter Shirley <ptrshrl@gmail.com> | ||
| // | ||
| // To the extent possible under law, the author(s) have dedicated all copyright and related and | ||
| // neighboring rights to this software to the public domain worldwide. This software is | ||
| // distributed without any warranty. | ||
| // | ||
| // You should have received a copy (see file COPYING.txt) of the CC0 Public Domain Dedication | ||
| // along with this software. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>. | ||
| //============================================================================================== |
There was a problem hiding this comment.
Fixed in next commit.
rupsis
reviewed
Apr 23, 2024
| bool scatter( | ||
| const ray& r_in, const hit_record& rec, color& attenuation, ray& scattered, double& pdf | ||
| ) const override { | ||
| double pdf_value; // TODO: What are we supposed to do with the returned PDF? |
There was a problem hiding this comment.
Is this TODO for the reader?
There was a problem hiding this comment.
No, things are bad enough at this point that I wanted to make sure all instances of this problematic code are flagged, so we don't miss a copy before shipping. It's also why I've updated images with obviously bad renders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor fixes.
Note that this shows the current state of some buggy renders, which render the entire scene as black, except for the single square light source.
Resolves #988
Resolves #1317