Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ray.time in scatter function #133

Closed
Bloov opened this issue Mar 6, 2017 · 3 comments
Closed

Missing ray.time in scatter function #133

Bloov opened this issue Mar 6, 2017 · 3 comments
Assignees
@hollasch
Labels
area: book book 2: Next Week
Milestone
v3.2.1

Comments

@Bloov
Copy link

Bloov commented Mar 6, 2017

It seems that you are forgotten to pass the r_in.time into the constructor of the scattered ray in some of materials.

motion_blur_error
@petershirley
Copy link
Collaborator

petershirley commented Mar 6, 2017 via email

@hollasch hollasch transferred this issue from RayTracing/TheNextWeek Aug 30, 2019
@hollasch hollasch transferred this issue from RayTracing/raytracing.github.io Aug 30, 2019
@hollasch hollasch transferred this issue from RayTracing/InOneWeekend Aug 30, 2019
@define-private-public
Copy link

This is still present in Book 2. The fix needs to be applied in metal and dielectric. The image in the online book also needs to be updated.

@hollasch hollasch reopened this Aug 18, 2020
@hollasch hollasch added this to the v3.2.1 milestone Aug 18, 2020
@hollasch hollasch assigned hollasch and unassigned hollasch Aug 18, 2020
@hollasch
Copy link
Collaborator

More specifically, listing 5 should apply the same modification to class metal and class dielectric.

@hollasch hollasch self-assigned this Sep 11, 2020
hollasch added a commit that referenced this issue Sep 11, 2020
@hollasch
Fix problems with material::scatter() methods
6221d4f 
- In book 1, the code for material::dielectric::scatter() divereged from
  the source code.

- In book 2, we neglected to include the code changes to handle ray time
  for material::metal and material::dielectric.

Resolves #133
@hollasch hollasch mentioned this issue Sep 11, 2020
Closed
hollasch added a commit that referenced this issue Sep 30, 2020
@hollasch
Fix problems with material::scatter() methods
b76285c 
- In book 1, the code for material::dielectric::scatter() divereged from
  the source code.

- In book 2, we neglected to include the code changes to handle ray time
  for material::metal and material::dielectric.

- In book 3, we neglected to include the code changes to handle specular
  updates to dielectric materials.

- Reformulated the dielectric::scatter() method for clarity.

Resolves #133
hollasch added a commit that referenced this issue Sep 30, 2020
@hollasch
Fix problems with material::scatter() methods
323592f 
- In book 1, the code for material::dielectric::scatter() divereged from
  the source code.

- In book 2, we neglected to include the code changes to handle ray time
  for material::metal and material::dielectric.

- In book 3, we neglected to include the code changes to handle specular
  updates to dielectric materials.

- Reformulated the dielectric::scatter() method for clarity.

Resolves #133
@hollasch hollasch mentioned this issue Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book book 2: Next Week
Projects
None yet
Milestone
v3.2.1
Development

No branches or pull requests
4 participants
@hollasch @Bloov @petershirley @define-private-public