Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit opportunities for defined constants #217

Closed
hollasch opened this issue Oct 19, 2019 · 1 comment
Closed

Revisit opportunities for defined constants #217

hollasch opened this issue Oct 19, 2019 · 1 comment
Assignees
@hollasch
Labels
area: book area: code
Milestone
v3

Comments

@hollasch
Copy link
Collaborator

There are many places where we use, for example, 180.0 / pi to convert between radians and degrees, or pi/4.0. When sensible, replace these with constants or utility functions defined in rtweekend.h.
@hollasch hollasch added this to the v3 milestone Oct 19, 2019
@hollasch hollasch self-assigned this Oct 19, 2019
hollasch pushed a commit that referenced this issue Oct 22, 2019
Add degrees_to_radians() utility function
6833c58 
Resolves #217
This was referenced Oct 22, 2019
Closed
Merged
@hollasch
Copy link
Collaborator Author

Resolved in #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book area: code
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

Add degrees_to_radians() utility function RayTracing/raytracing.github.io
1 participant
@hollasch