Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add drawing for sphere directions #326

Closed
trevordblack opened this issue Jan 17, 2020 · 9 comments
Closed

Need to add drawing for sphere directions #326

trevordblack opened this issue Jan 17, 2020 · 9 comments
Assignees
Milestone

Comments

@trevordblack
Copy link
Collaborator

Missing white board picture for possible sphere normal directions, see
InOneWeekend.html:794

@trevordblack trevordblack added this to the v3 milestone Jan 17, 2020
@hollasch
Copy link
Collaborator

Hmmmm, that's a blank line in the middle of a code block at the current tip of the development branch. What's the surrounding text?

@trevordblack
Copy link
Collaborator Author

![Figure [normal-directions]: Possible directions for sphere surface-normal geometry](../images/fig.normal-possibilities.jpg)

I realized that 794 is in my current branch

@hollasch
Copy link
Collaborator

@trevordblack — can you sketch out a picture of what you're thinking of?

@trevordblack
Copy link
Collaborator Author

Ahahahahahahah, you can't make me fall for that!

But, I'll throw something together. I had a limnu account that lapsed. I'll try to draw something

@hollasch
Copy link
Collaborator

A picture of a paper sketch would be fine.

@trevordblack
Copy link
Collaborator Author

trevordblack commented Jan 22, 2020

IMG_20200122_145701

The plane should be a saturated cyan/teal.
The point of intersection a deep red.
The ray_in black
The normals a bright green

@trevordblack
Copy link
Collaborator Author

Shoulda gone to art school

@petershirley
Copy link
Collaborator

Figure fig.normal-possibilities.jpg checked into branch v3newfigures
image

hollasch pushed a commit that referenced this issue Mar 23, 2020
For In One Weekend, figure [normal-directions].

Fixes #326
@hollasch
Copy link
Collaborator

Fixed in #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants