Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[In one Weekend] cam::get_ray input parameters sudden change #616

Closed
mratsim opened this issue May 23, 2020 · 2 comments
Closed

[In one Weekend] cam::get_ray input parameters sudden change #616

mratsim opened this issue May 23, 2020 · 2 comments
Assignees
@hollasch
Labels
area: book book 1: One Weekend
Milestone
v3.2.0

Comments

@mratsim
Copy link

mratsim commented May 23, 2020

Looking into the camera implementation, the initial parameters where u, v and they changed to s, t without highlighting.

I assume they were supposed to be u, v to keep in line with the figures and s, t was a leftover from a previous change.

image
image
@hollasch hollasch added this to the v3.2.0 milestone May 23, 2020
@hollasch hollasch self-assigned this May 23, 2020
@hollasch
Copy link
Collaborator

Thank you. Yes, I actually noticed (and have a correction for this) yesterday, when I went through the entire book. Lots of little mistakes to be fixed in book 1, including this one.

Keeping this one open, as I haven't created separate issues for the problems I've encountered.

hollasch added a commit that referenced this issue May 24, 2020
@hollasch
Fix highlighting in listing 62
cb43583 
`camera::get_ray()` parameters renamed from `u,v` to `s,t`.

Resolves #616
@hollasch
Copy link
Collaborator

Resolved in PR #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book book 1: One Weekend
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@hollasch @mratsim