-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render updates 3 #625
Render updates 3 #625
Conversation
- Add extra blank line before code listing highlighting changes - Add missing text change highlights - Add missing header includes - Organize main() chunks: image params, then world def, then camera def, then image render - Images parameters updated for new renders - Some code listings get more context - Fix trivial code format issues - Add missing code listings - Side-by-side antialising illustration - Fix source file name error for fig-1.09 - Change render image includes to use new names (coming in next commit) - Improve code for distinct world material + geometry definitions - Include render parameters for final scene
- Add more double-line spacers - Organize main() chunks: image params, then world definitions, then camera defs, then render - Change class order in material.h to match book definition order - Eliminate duplicated code in dielectric::scatter() - Delete vestigal vec3::write_color() method (now in color.h)
img-1.14-glass-always-refracts.png is incorrect. |
After replacing that image, it's approved. |
The code is broken at this point. img-1.13 has no corresponding source (I don't know how it was rendered), and 1.14 is broken from the reflection/refract/front-face changes. Keeping it in for now, rather than suggesting that readers should expect some other result. |
BTW, we can at least now use the progression branch to get to a good debugging point for issues like this. |
See #179
Book 1 render updates: text changes
Book 1 render updates: code changes