Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render updates 3 #625

Merged
merged 4 commits into from
May 29, 2020
Merged

Render updates 3 #625

merged 4 commits into from
May 29, 2020

Conversation

hollasch
Copy link
Collaborator

See #179

Book 1 render updates: text changes

  • Add extra blank line before code listing highlighting changes
  • Add missing text change highlights
  • Add missing header includes
  • Organize main() chunks: image params, then world def, then camera def,
  • then image render
  • Images parameters updated for new renders
  • Some code listings get more context
  • Fix trivial code format issues
  • Add missing code listings
  • Side-by-side antialising illustration
  • Fix source file name error for fig-1.09
  • Change render image includes to use new names (coming in next commit)
  • Improve code for distinct world material + geometry definitions
  • Include render parameters for final scene

Book 1 render updates: code changes

  • Add more double-line spacers
  • Organize main() chunks: image params, then world definitions, then
  • camera defs, then render
  • Change class order in material.h to match book definition order
  • Eliminate duplicated code in dielectric::scatter()
  • Delete vestigal vec3::write_color() method (now in color.h)

- Add extra blank line before code listing highlighting changes
- Add missing text change highlights
- Add missing header includes
- Organize main() chunks: image params, then world def, then camera def,
  then image render
- Images parameters updated for new renders
- Some code listings get more context
- Fix trivial code format issues
- Add missing code listings
- Side-by-side antialising illustration
- Fix source file name error for fig-1.09
- Change render image includes to use new names (coming in next commit)
- Improve code for distinct world material + geometry definitions
- Include render parameters for final scene
- Add more double-line spacers
- Organize main() chunks: image params, then world definitions, then
  camera defs, then render
- Change class order in material.h to match book definition order
- Eliminate duplicated code in dielectric::scatter()
- Delete vestigal vec3::write_color() method (now in color.h)
See #179
Resolves #547
Resolves #548
Resolves #549
Resolves #550
Resolves #551
Resolves #552
Resolves #553
Resolves #554
Resolves #555
Resolves #556
Resolves #557
Resolves #560
Resolves #561
Resolves #562
Resolves #563
Resolves #564
Resolves #565
Resolves #566
@hollasch hollasch added this to the v3.2.0 milestone May 29, 2020
@hollasch hollasch requested review from trevordblack and a team May 29, 2020 04:33
@hollasch hollasch self-assigned this May 29, 2020
@hollasch hollasch mentioned this pull request May 29, 2020
@trevordblack
Copy link
Collaborator

img-1.14-glass-always-refracts.png is incorrect.
However. It is delightful.

@trevordblack
Copy link
Collaborator

After replacing that image, it's approved.

@hollasch
Copy link
Collaborator Author

The code is broken at this point. img-1.13 has no corresponding source (I don't know how it was rendered), and 1.14 is broken from the reflection/refract/front-face changes. Keeping it in for now, rather than suggesting that readers should expect some other result.

See #558, #559 -- these are not resolved in this merge.

@hollasch
Copy link
Collaborator Author

BTW, we can at least now use the progression branch to get to a good debugging point for issues like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants