Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material.isotropic should have a constructor that takes a color value, like other materials #644

Closed
hollasch opened this issue Jun 22, 2020 · 1 comment
Closed

material.isotropic should have a constructor that takes a color value, like other materials #644

hollasch opened this issue Jun 22, 2020 · 1 comment
Assignees
@hollasch
Labels
area: book area: code book 2: Next Week book 3: Your Life
Milestone
v3.2.0

Comments

@hollasch
Copy link
Collaborator

Such as lambertian and diffuse_light.
@hollasch hollasch added this to the v3.2.0 milestone Jun 22, 2020
@hollasch hollasch self-assigned this Jun 22, 2020
@trevordblack
Copy link
Collaborator

We're never going to stop finding small things to change....

@hollasch hollasch mentioned this issue Jun 22, 2020
Merged
hollasch added a commit that referenced this issue Jun 24, 2020
@hollasch
Add isotropic constructor taking color argument
de252c7 
Resolves #644
@hollasch hollasch mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book area: code book 2: Next Week book 3: Your Life
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@hollasch @trevordblack