Update Book 1 screenshot images without severe JPG artifacts, and with fixed diffuse #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… artifacts (RayTracing#179). I ran PNGs through pngquant+Zopfli to produce smallest possible sizes, but each image is a kilobyte or two larger than the previous JPG still. The diffuse images are produced with the diffuse fix (RayTracing#181).
…tifacts (RayTracing#179). I ran PNGs through pngquant+Zopfli to produce smallest possible sizes, but each image is several kilobytes larger than the previous JPG. The images are produced with the diffuse fix (RayTracing#181). Also fixed the example in chapter 9 to compile (metal does not have fuzz parameter yet), and use a similar red color as in the image, instead of blue.
…rtifacts (RayTracing#179). The first ("totally wrong") image had no source for it, so I could not reproduce it to exact match.
|
Ok, v2.0.0 is out the door, now we can focus on v3. Changes in this PR will be reviewed for that target. @aras-p — pull requests should be preceded by an existing issue, so we can plan around releases and assignments. Also, one PR ↔ one issue. This PR needs to be made against the latest version now, and should also be separated into individual PRs, with references to their associated issue. Let me know if you want to tackle this. If not, I'll rework this PR into individual ones, and would request your review. |
|
I can rework this, but in a few days from now. |
hollasch
added a commit
that referenced
this pull request
Oct 21, 2019
This is copied from PR #182, targeting the development branch. Original commentary: Ran the PNGs through pngquant+Zopfli to reduce file sizes, but as expected they are a bit larger. All the images add ~180 kilobytes to previous book size. Also the fix for "incorrect" diffuse (#181) is reflected in the screenshots. Resulting AO effect is slightly less intense than before, but more correct. Also in one place fixed source to compile and the color in the source to match the color of the sphere in the screenshot. Images in Book 2 and 3 are "not too bad"; they are larger and JPG artifacts aren't as visible there. Also they are much slower to render, and I'm lazy... :)
|
Now superseded by PR #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #179 - the screenshots are really low quality JPGs. I've regenerated all the screenshots in Book 1 as PNGs.
Ran the PNGs through pngquant+Zopfli to reduce file sizes, but as expected they are a bit larger. All the images add ~180 kilobytes to previous book size.
Also the fix for "incorrect" diffuse (#181) is reflected in the screenshots. Resulting AO effect is slightly less intense than before, but more correct.
Also in one place fixed source to compile and the color in the source to match the color of the sphere in the screenshot.
Images in Book 2 and 3 are "not too bad"; they are larger and JPG artifacts aren't as visible there. Also they are much slower to render, and I'm lazy... :)