Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better name for NoiseModule #121

Closed
brendanzab opened this issue Jul 11, 2016 · 3 comments
Closed

Figure out a better name for NoiseModule #121

brendanzab opened this issue Jul 11, 2016 · 3 comments
Labels

Comments

@brendanzab
Copy link
Collaborator

No description provided.

@Razaekel
Copy link
Owner

Suggested Names:

  • Module
  • NoiseModule (I prefer this, obviously)
  • ModuleBase
  • ValueSource ( I don't like this one because not all of the noisemodules will be sourcing values, most will be either modifying the value or modifying the point.)

@brendanzab
Copy link
Collaborator Author

  • NoiseGen
  • NoiseFn
  • GenFn

In the future I see that these structs could simply implement Fn(Input) -> Output, but we need to wait for these to be stabilized first.

I also think that we need an impl for Fn.

@Razaekel
Copy link
Owner

Based off of the synonyms for module, here are other potential names:

  • NoiseComponent
  • NoiseUnit
  • NoiseElement

amaranth pushed a commit that referenced this issue Jun 24, 2017
As covered in Issue #121, this renames NoiseModule to NoiseFn. Also, update all the comments to reflect the change.

Closes #121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants