Skip to content

Commit

Permalink
re-enable linux and mac builds, cleanup packaging, more windows x86_6…
Browse files Browse the repository at this point in the history
…4 fixes
  • Loading branch information
Razish committed Oct 14, 2023
1 parent 9fad407 commit ef9e896
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ jobs:

ubuntu:
name: Ubuntu ${{ matrix.arch }} ${{ matrix.build_type }}
if: ${{ false }} # disable for now
runs-on: ubuntu-22.04
strategy:
fail-fast: false
Expand Down Expand Up @@ -142,7 +141,6 @@ jobs:

macos:
name: macOS ${{ matrix.arch }} ${{ matrix.build_type }}
if: ${{ false }} # disable for now
runs-on: macos-12
strategy:
fail-fast: false
Expand Down Expand Up @@ -192,8 +190,8 @@ jobs:

- name: Create binary archives
run: |
7z a -r japp-windows-x86.zip ./japp-windows-x86-Release/* '-x!msvcp*.*' '-x!vcruntime*.*' '-x!concrt*.*'
7z a -r japp-windows-x86_64.zip ./japp-windows-x86_64-Release/* '-x!msvcp*.*' '-x!vcruntime*.*' '-x!concrt*.*'
7z a -r japp-windows-x86.zip ./japp-windows-x86-Release/*
7z a -r japp-windows-x86_64.zip ./japp-windows-x86_64-Release/*
mv ./japp-linux-x86-Release/* japp-linux-x86.tar.gz
mv ./japp-linux-x86_64-Release/* japp-linux-x86_64.tar.gz
mv ./japp-macos-x86_64-Release/* japp-macos-x86_64.tar.gz
Expand Down Expand Up @@ -247,7 +245,7 @@ jobs:
- name: Create archive
run: |
if [ "${{ matrix.zip }}" == "true" ]; then
7z a -r ${{ matrix.artifact_name }} ./${{ matrix.artifact_dir }}/* '-x!msvcp*.*' '-x!vcruntime*.*' '-x!concrt*.*'
7z a -r ${{ matrix.artifact_name }} ./${{ matrix.artifact_dir }}/*
else
mv ./${{ matrix.artifact_dir }}/* ${{ matrix.artifact_name }}
fi
Expand Down
9 changes: 8 additions & 1 deletion SConstruct
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,15 @@ elif env["CC"] == "cl":
env["LINKFLAGS"] += [
"/ERRORREPORT:none", # don't send error reports for internal linker errors
"/NOLOGO", # remove watermark
"/MACHINE:" + arch, # 32/64 bit linking
]
if arch == "x86_64":
env["LINKFLAGS"] += [
"/MACHINE:X64",
]
else:
env["LINKFLAGS"] += [
"/MACHINE:" + arch,
]
if bits == 64:
env["LINKFLAGS"] += [
"/SUBSYSTEM:WINDOWS", # graphical application
Expand Down

0 comments on commit ef9e896

Please sign in to comment.