Closes #2475 -- setnames on a table with NA names works as expected

[MichaelChirico]

Other option would be something like which(!vapply(seq_along(old), function(ii) nx[ii] == old[ii], logical(1L))). Looks ugly and efficiency gain (if any) probably trivial

[codecov-io]

Codecov Report

Merging #2477 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2477      +/-   ##
==========================================
+ Coverage   91.57%   91.58%   +<.01%     
==========================================
  Files          63       63              
  Lines       12037    12044       +7     
==========================================
+ Hits        11023    11030       +7     
  Misses       1014     1014

Impacted Files	Coverage Δ
R/data.table.R	97.17% <100%> (ø)	⬆️
src/fwrite.c	91.22% <0%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e334ed1...7a0eb20. Read the comment docs.

[jangorecki]

This PR broke R 3.0.0 compatibility (which is currently broken by another commit but it is irrelevant here) because there is no anyNA function in R 3.0.0. @MichaelChirico

[MichaelChirico]

oh darn. should we test R version, or just use any(is.na())?

…

On Nov 14, 2017 9:44 PM, "Jan Gorecki" ***@***.***> wrote: This PR broke R 3.0.0 compatibility (which is currently broken by another commit but it is not relevant here) because there is no anyNA function in R 3.0.0. @MichaelChirico <https://github.com/michaelchirico> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2477 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQdRYiw_GYj-6frqADf8B0pATnEowJks5s2Zk-gaJpZM4QbLAz> .

[jangorecki]

Testing R version... makes sense for very wide tables, million of columns, which is not very common scenario but it is probably worth extra if in the code. There might be a C function in data.table code for anyNA, not sure, this would be the best to use.