Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a note about when .N is computed #4696

Merged
merged 2 commits into from
May 11, 2021
Merged

add a note about when .N is computed #4696

merged 2 commits into from
May 11, 2021

Conversation

MichaelChirico
Copy link
Member

Hoping to make clear in the documentation that .N in i may not be the same as .N in j. A subtle point inspired by #4695 -- if we allow all the symbols in both i and j, it might get a bit confusing to have them all "overloaded" in the sense that there's this subtle difference between what they mean in i vs j

@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #4696 (c710bb6) into master (a507ed5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4696   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          73       73           
  Lines       14455    14455           
=======================================
  Hits        14372    14372           
  Misses         83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a507ed5...c710bb6. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.1 milestone May 11, 2021
@mattdowle mattdowle merged commit 19c61c0 into master May 11, 2021
@mattdowle mattdowle deleted the symbols-docs branch May 11, 2021 00:50
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants