-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use R 3.2.0 features #5838
Use R 3.2.0 features #5838
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5838 +/- ##
==========================================
- Coverage 97.51% 97.48% -0.04%
==========================================
Files 80 80
Lines 14979 14859 -120
==========================================
- Hits 14607 14485 -122
- Misses 372 374 +2 ☔ View full report in Codecov by Sentry. |
@jangorecki anything to change here before merging to |
In some PRs I recall using 3.1's (vapply's) |
Still it would be good to turn on 3.2.0 ASAP to allow using the new functions. WDYT about this approach:
That way, we're "allowed" to use 3.2.0 sooner, but only "enforce" doing so all at once. |
1edf380
to
f658ff4
Compare
0ff8f67
to
8e2cc18
Compare
Generated via commit 3cf6328 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 27 seconds Time taken to run |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on |
* Fix 5492 by limiting the costly deparse to `nlines=1` * Implementing PR feedbacks * Added inside * Fix typo in name * Idiomatic use of inside * Separating the deparse line limit to a different PR --------- Co-authored-by: Michael Chirico <chiricom@google.com>
* Updated documentation for rbindlist(fill=TRUE) * Print NULL entries of list as NULL * Added news item * edit NEWS, use '[NULL]' not 'NULL' * fix test * split NEWS item * add example --------- Co-authored-by: Michael Chirico <chiricom@google.com> Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Benjamin Schwendinger <benjamin.schwendinger@tuwien.ac.at>
Thanks for the reviews @tdhock, this PR is also part of the same "stack" -- I can submit them all at once with your review here. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks
Merge activity
|
Newly-available functions taken from here:
https://github.com/r-lib/lintr/blob/f00f4a9a715346a3e696aab9cffff2756833e50a/R/backport_linter.R#L152-L159
Most significant are
lengths()
,trimws()
, andstrrep()
.