New linter for test(symbol) #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on |
|
great but do we need to turn off the linter in |
it only happens once now in tests.Rraw (hence the nolint). It happens a few more times in froll, hence the config entry in #6121. I'd rather not touch those tests until the existing froll PRs are eventually cleared. |
|
great |
MichaelChirico
force-pushed
the
lint-lengths
branch
from
2832585
to
99b0b23
Compare
MichaelChirico
force-pushed
the
05-02-lint-test-literal
branch
from
00b1406
to
1d045f8
Compare
tdhock
approved these changes
May 3, 2024
jangorecki
approved these changes
May 4, 2024
Merge activity
|
MichaelChirico
force-pushed
the
lint-lengths
branch
from
99b0b23
to
dc2d6ed
Compare
MichaelChirico
force-pushed
the
05-02-lint-test-literal
branch
from
1d045f8
to
ed0d93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6041 that will prevent regression on that front going forward.