Periodic log flushing

Fix some compile Wreorder warnings.

recodex-broker.spec

@@ -14,7 +14,7 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
 Prefix: %{_prefix}
 Vendor: Petr Stefan <UNKNOWN>
 Url: https://github.com/ReCodEx/broker
-BuildRequires: systemd cmake
+BuildRequires: systemd cmake zeromq-devel cppzmq-devel yaml-cpp-devel libcurl-devel spdlog-devel
 Requires(post): systemd
 Requires(preun): systemd
 Requires(postun): systemd

src/broker_core.cpp

@@ -104,8 +104,8 @@ void broker_core::log_init()
 				log_conf.log_suffix,
 				log_conf.log_file_size,
 				log_conf.log_files_count);
-		// Set queue size for asynchronous logging. It must be a power of 2.
-		spdlog::set_async_mode(1048576);
+		// Set queue size for asynchronous logging. It must be a power of 2. Also, flush every 2 seconds.
+		spdlog::set_async_mode(1048576, spdlog::async_overflow_policy::block_retry, nullptr, std::chrono::seconds(2));
 		// Make log with name "logger"
 		logger_ = std::make_shared<spdlog::logger>("logger", rotating_sink);
 		// Set logging level to debug

src/handlers/broker_handler.cpp

@@ -226,7 +226,9 @@ void broker_handler::process_worker_done(
 
 	if (message.at(1) != current->data.get_job_id()) {
 		logger_->error("Got 'done' message from worker {} with mismatched job id - {} (message) vs. {} (worker)",
-			worker->get_description(), message.at(1), current->data.get_job_id());
+			worker->get_description(),
+			message.at(1),
+			current->data.get_job_id());
 		return;
 	}
 

src/worker.cpp

@@ -65,7 +65,7 @@ class count_matcher : public header_matcher
 	 * Constructor.
 	 * @param my_value Base value for comparison. Will be converted to @a size_t type using std::stoul.
 	 */
-	count_matcher(std::string my_value) : my_count_(std::stoul(my_value)), header_matcher(my_value)
+	count_matcher(std::string my_value) : header_matcher(my_value), my_count_(std::stoul(my_value))
 	{
 	}
 
@@ -88,7 +88,7 @@ class count_matcher : public header_matcher
 
 worker::worker(
 	const std::string &id, const std::string &hwgroup, const std::multimap<std::string, std::string> &headers)
-	: identity(id), hwgroup(hwgroup), free_(true), current_request_(nullptr), headers_copy_(headers)
+	: headers_copy_(headers), free_(true), current_request_(nullptr), identity(id), hwgroup(hwgroup)
 {
 	headers_.emplace("hwgroup", std::unique_ptr<header_matcher>(new multiple_string_matcher(hwgroup)));