Implement a configurable modifier indicator color #19
Conversation
|
As with the other PR. it would be great if you could open a PR to document this config option in the config repo |
khoek
force-pushed
the
adv360-mod-color
branch
2 times, most recently
from
43af6d9
to
dfc398b
Compare
|
Documentation done in KinesisCorporation/Adv360-Pro-ZMK#431. I hope you think it looks OK! Sorry about the noise, I rebased couple times a little too eagerly while I changed what was underneath. All done now. |
|
One last docs related thing. We changelog work to the base firmware too, so could you rebase your docs PR off the zephyr 3.5 PR (KinesisCorporation/Adv360-Pro-ZMK#426) and append the base repo changelog and config repo changelog accordingly please? I'll try and find the time to test all your work today and will merge in as soon as it all tests well |
|
No worries. Hopefully I've changelogged things correctly now. BTW, this is me just selfishly asking now: I found a race condition in the USB HID code zmkfirmware#2257 which unfortunately affects the Adv360's SoC, and so stopped my > |
|
As a general rule i try to avoid jumping the queue on pulling upstream PRs into the 360 pro's branch as there';s usually a conflict to resolve when that happens (such as the different naming of the extended nkro kconfig). I can see your PR is not that big, so i might cherry pick it if it doesn't get reviewed in the next few weeks |
|
Sorry, more conflicts that need to be untangled here |
|
No worries, rebased again. |
|
Thank you very much for all your work on these features! |
|
Regarding your upstream USB PR, given it looks like it might be going all the way up to to the hal driver level I could be open to merging a short term fix now |
Built on top of #18. We add a Kconfig option for the modifier CAPS/SCOLL/NUM LOCK indicator LEDs, allowing their color to be configured, so that e.g. their accidental activation is more distinguishable. Tested on a real Adv360 Pro.