Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new layer colors and modifier color configuration option #431

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

khoek
Copy link
Contributor

@khoek khoek commented Apr 7, 2024

Add documentation for ReFil/zmk#18 and ReFil/zmk#19.

Here it is rendered.

@ReFil
Copy link
Collaborator

ReFil commented Apr 8, 2024

CONFIG_ZMK_RGB_UNDERGLOW_MOD_COLOR needs to be set on both sides right? it may be worth clarifying that in the docs

@khoek
Copy link
Contributor Author

khoek commented Apr 10, 2024

Sorry, I'd missed this.

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Please can you rebase as there were some other changes to the zephyr 3.5 PR? It would also be good if you could link to the base ZMK PR's in the changelog entries. Thank you

@khoek
Copy link
Contributor Author

khoek commented Apr 15, 2024

How does that look?

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Spot on, thank you very much!

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Waiting for build job then i'll hit merge, thank you again for all your work on these features <3

@ReFil ReFil merged commit 41e734c into KinesisCorporation:V3.0 Apr 15, 2024
1 check passed
@khoek khoek deleted the new-docs branch April 15, 2024 11:30
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
gabrielfreiberg added a commit to gabrielfreiberg/Adv360-Pro-ZMK that referenced this pull request May 5, 2024
* upstream_V3.0:
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
gabrielfreiberg added a commit to gabrielfreiberg/Adv360-Pro-ZMK that referenced this pull request May 5, 2024
* main:
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants