Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile fails to build due to ubi_reader changes #658

Open
whoami-defnotme opened this issue Sep 22, 2023 · 1 comment
Open

Dockerfile fails to build due to ubi_reader changes #658

whoami-defnotme opened this issue Sep 22, 2023 · 1 comment

Comments

@whoami-defnotme
Copy link

I received build errors while trying to build an image using the current Dockerfile in this repo.

ubi_reader now uses main as the default branch instead of master and no longer uses a setup.py file.

I was able to change this function in deps.sh to simply use the following command (recommended from ubi_reader and was able to successfully build the Docker image:

install_pip_package "ubi_reader"

I'm not sure if this is the code change you want or if you'd rather change the install_ubireader to directly install from source so I'm just raising this as an issue instead of providing this as a PR.

@vincejv
Copy link

vincejv commented Oct 4, 2023

thanks for this! was able to run binwalk successfully from docker, i hope the maintainers have the time to update the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants