Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shukla2022re #95

Merged
merged 6 commits into from
May 15, 2022
Merged

shukla2022re #95

merged 6 commits into from
May 15, 2022

Conversation

Viswesh-N
Copy link
Contributor

Project Name

Write the <paper_citekey> here, and as well as rename the PR name to reflect the <paper_citekey> for quick reviewing.

Compiled PDF

Add the link to the compiled pdf here. Example : Compiled Pdf

Metadata Checklist

Ensure that you have added the following metadata information (put an x to the checkbox items) in <paper_citekey>/journal/metadata.yaml.

  • title field exists and it starts with [Re] .
  • authors contain author information with affiliations.
  • ORCID id is provided for authors.
  • One contact author is added using *.
  • Github url is provided in code section.
  • SWH identifier is provided in swh.
  • replication section is populated with the necessary information about the paper you reproduced.
  • abstract field is populated with your paper abstract (including double quotes)
  • domain should contain "ML Reproducibility Challenge 2021"
  • review section contains the url to the OpenReview forum of your paper.
  • Fields contributors, dates, article and journal are kept blank, as those will be populated by the Area Chairs / ReScience editors.

Build Errors

If your build had any errors locally, please add it here. You can upload your build.log in a Pastebin link and put it here.

@Viswesh-N Viswesh-N changed the title Changes shukla2022re May 3, 2022
@koustuvsinha koustuvsinha added the compilation issue Something isn't working label May 4, 2022
% \usepackage[nonatbib]{neurips_2019}

\usepackage[utf8]{inputenc} % allow utf-8 input
\usepackage[T1]{fontenc} % use 8-bit T1 fonts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this import (fontenc - already described in README)

\usepackage{nicefrac} % compact symbols for 1/2, etc.
\usepackage{microtype} % microtypography

\usepackage[dvipsnames]{xcolor}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove this import (already described in README)

@Viswesh-N
Copy link
Contributor Author

Made the changes as instructed above. The error still seems to persist.

# - For a failed replication, it should be prefixed with "[¬Re]"
# - For other article types, no instruction (but please, not too long)
# Change the default title
title: "[Re] From goals, waypoints & paths to longterm human trajectory forecasting"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace & in title with and


% [Train test split doesn't exist (yet). Would be better for someone like Shubhendu, who had recently tried preprocessing this data, to flesh out this section-- I don't really remember what all was done anymore.]

\newline
Copy link
Member

@koustuvsinha koustuvsinha May 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment / remove this newline.

\usepackage{amsfonts} % blackboard math symbols
\usepackage{nicefrac} % compact symbols for 1/2, etc.
\usepackage{microtype} % microtypography

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you use subfigure in your content, add the following import:

\usepackage{subfigure}

@koustuvsinha koustuvsinha added the update requested Update is requested from the authors label May 8, 2022
@koustuvsinha koustuvsinha added latex ok Latex content reviewed to be consistent with ReScience and removed compilation issue Something isn't working update requested Update is requested from the authors labels May 15, 2022
@koustuvsinha koustuvsinha merged commit a2aa15b into ReScience:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
latex ok Latex content reviewed to be consistent with ReScience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants