Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new function in baseline module and added testing #298

Merged
merged 2 commits into from
May 27, 2024

Conversation

ElineOppersma
Copy link
Collaborator

detect peak, start and end of breath in envelope signal, and added testing for 3 functions in module baseline

@rspwarnaarUT
Copy link
Collaborator

The new functions generally did what they need to do, except for the baseline_window. The latter was already entered as samples as variable and once more multiplied by the sampling frequency.
Many functions however did too many things to keep them clear (slicing of input signals, peak detection). I cut those parts out.

Copy link
Collaborator

@rspwarnaarUT rspwarnaarUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review my changes

@ElineOppersma ElineOppersma merged commit fd24746 into main May 27, 2024
3 checks passed
@rspwarnaarUT rspwarnaarUT deleted the eoppersma/baselinefunc1 branch May 27, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants