Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftPM manifest file #403

Merged
merged 7 commits into from
Apr 8, 2019
Merged

Update SwiftPM manifest file #403

merged 7 commits into from
Apr 8, 2019

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Apr 1, 2019

This adds support for SwiftPM manifest based dependency managers. Specifically this adds support for installing via Accio but will probably also work with SwiftPM once it's integrated into Xcode.

@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #403 into master will increase coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   97.96%   99.42%   +1.45%     
==========================================
  Files          16        5      -11     
  Lines         985      174     -811     
==========================================
- Hits          965      173     -792     
+ Misses         20        1      -19
Impacted Files Coverage Δ
ReSwiftTests/XCTest+Compatibility.swift
ReSwiftTests/TypeHelperTests.swift
ReSwiftTests/TestFakes.swift
ReSwiftTests/AutomaticallySkipRepeatsTests.swift
ReSwiftTests/StoreTests.swift
ReSwiftTests/XCTest+Assertions.swift
ReSwiftTests/StoreSubscriberTests.swift
ReSwiftTests/PerformanceTests.swift
ReSwiftTests/StoreMiddlewareTests.swift
ReSwiftTests/StoreSubscriptionTests.swift
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b228e6...e923ce6. Read the comment docs.

@mjarvis
Copy link
Member

mjarvis commented Apr 4, 2019

@Dschee Many thanks for your contribution! Is there a way that we can have a CI job to lint / build via swift PM to ensure that this is setup correctly?

@Jeehut
Copy link
Contributor Author

Jeehut commented Apr 5, 2019

Hey @mjarvis, of course there are ways to configure SwiftPM support and Accio support are checked on the CI. I'm not sure how to do it in Travis CI though, but the basic ideas are:

For testing SwiftPM support:
Run swift test from the projects root directory of a macOS machine having at least Xcode 10.1 installed.

For testing Linux support:
The same as for SwiftPM support, but on a Ubuntu machine after installing the Swift Ubuntu toolset.

Accio support is automatically given if you support SwiftPM and Carthage. Actually, currently there is no command to test the support without creating a Package.swift file that includes your repo like I've already setup in the Demo project at Accio. But I just created JamitLabs/Accio#16 to make sure we add such a feature over time.

@Jeehut
Copy link
Contributor Author

Jeehut commented Apr 5, 2019

I just looked into some Travis CI config files and found that PromiseKit is testing SwiftPM support by running swift build (which basically tests installability and skips the tests) here. You can also find a way on how you could add Linux tests there, too.

I hope that helps.

@mjarvis mjarvis self-assigned this Apr 5, 2019
@mjarvis
Copy link
Member

mjarvis commented Apr 5, 2019

Many thanks I'll look those over and update our CI config.

@mjarvis mjarvis merged commit 941d85d into ReSwift:master Apr 8, 2019
@peril-reswift
Copy link

peril-reswift bot commented Apr 8, 2019

@Dschee Thanks a lot for contributing to ReSwift! We've invited you to join
the ReSwift GitHub organization – no pressure to accept! If you'd like more
information on what that means, check out our contributor guidelines.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants