-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SwiftPM manifest file #403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 97.96% 99.42% +1.45%
==========================================
Files 16 5 -11
Lines 985 174 -811
==========================================
- Hits 965 173 -792
+ Misses 20 1 -19 Continue to review full report at Codecov.
|
@Dschee Many thanks for your contribution! Is there a way that we can have a CI job to lint / build via swift PM to ensure that this is setup correctly? |
Hey @mjarvis, of course there are ways to configure SwiftPM support and Accio support are checked on the CI. I'm not sure how to do it in Travis CI though, but the basic ideas are: For testing SwiftPM support: For testing Linux support: Accio support is automatically given if you support SwiftPM and Carthage. Actually, currently there is no command to test the support without creating a Package.swift file that includes your repo like I've already setup in the Demo project at Accio. But I just created JamitLabs/Accio#16 to make sure we add such a feature over time. |
I just looked into some Travis CI config files and found that PromiseKit is testing SwiftPM support by running I hope that helps. |
Many thanks I'll look those over and update our CI config. |
@Dschee Thanks a lot for contributing to ReSwift! We've invited you to join Generated by 🚫 dangerJS |
This adds support for SwiftPM manifest based dependency managers. Specifically this adds support for installing via Accio but will probably also work with SwiftPM once it's integrated into Xcode.