Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Comments): Add option to hide timestamp and emoji buttons #621

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

Integration changes for ReVanced/revanced-patches#3076

Also includes minor reorganization of YT Settings.java

@MarcaDian
Copy link
Contributor

MarcaDian commented Apr 23, 2024

Some users tell that they can't disable this toggles, after reboot they still enabled, maybe its time to remove that code?

// Shorts
        if (DEPRECATED_HIDE_SHORTS.get()) {
            Logger.printInfo(() -> "Migrating hide Shorts setting");
            DEPRECATED_HIDE_SHORTS.resetToDefault();
            HIDE_SHORTS_HOME.save(true);
            HIDE_SHORTS_SUBSCRIPTIONS.save(true);
            HIDE_SHORTS_SEARCH.save(true);
        }

@LisoUseInAIKyrios
Copy link
Contributor Author

That migration code only runs once, and then cannot run again because it resets to default.

I think the users are doing something else wrong.

But since there is now fine grained hiding options, forcing the user to pick again is not such a bad thing.

@oSumAtrIX oSumAtrIX changed the title feat(YouTube - Comments): Hide timestamp and emoji buttons feat(YouTube - Comments): Add option to hide timestamp and emoji buttons Apr 23, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 6e9e122 into ReVanced:dev Apr 23, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the hide_emoji_comment_picker branch April 23, 2024 17:03
revanced-bot pushed a commit that referenced this pull request Apr 23, 2024
# [1.9.0-dev.2](v1.9.0-dev.1...v1.9.0-dev.2) (2024-04-23)

### Features

* **YouTube - Comments:** Add option to hide timestamp and emoji buttons ([#621](#621)) ([6e9e122](6e9e122))
revanced-bot pushed a commit that referenced this pull request May 21, 2024
# [1.9.0](v1.8.0...v1.9.0) (2024-05-21)

### Bug Fixes

* Use Java instead of Kotlin Regex to improve reliability ([#628](#628)) ([44c3cc4](44c3cc4))
* **YouTube - Client spoof:** Spoof client to fix playback ([#637](#637)) ([4c1f82a](4c1f82a))
* **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([75fa579](75fa579))
* **YouTube - Hide Shorts components:** Hide old layout like/dislike buttons without leaving empty space ([9782338](9782338))
* **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([#625](#625)) ([656ca17](656ca17))
* **YouTube - Hide video action buttons:** Remove obsolete `hide Shop button` ([#618](#618)) ([a78c3ff](a78c3ff))
* **YouTube - Hide video action buttons:** Updated path filter ([b74e544](b74e544))
* **YouTube - Player flyout menu:** Remove obsolete `Hide report menu` ([9e9d969](9e9d969))
* **YouTube - Restore old video quality menu:** Do not make click sounds when opening Shorts quality menu ([578a27d](578a27d))
* **YouTube - Restore old video quality menu:** Show advanced quality menu in Shorts quality flyout ([#632](#632)) ([77c9825](77c9825))
* **YouTube - Settings:** Use same background color for about screen if Theme patch is not included ([4164ed3](4164ed3))
* **YouTube - SponsorBlock:** Show correct segment times if video is over 24 hours in length ([#630](#630)) ([81251f9](81251f9))

### Features

* **YouTube - Comments:** Add option to hide timestamp and emoji buttons ([#621](#621)) ([6e9e122](6e9e122))
* **YouTube - Hide ads:** Add option to hide the 'Visit store' button on channel pages ([#622](#622)) ([9de566c](9de566c))
* **YouTube - Hide Shorts components:** Hide 'Buy super thanks' button ([#633](#633)) ([303754c](303754c))
* **YouTube - Hide Shorts components:** Hide like / dislike button in video ads ([#619](#619)) ([b2b6b8c](b2b6b8c))
* **YouTube - Navigation buttons:** Add option to hide navigation button labels ([#635](#635)) ([6bd0ac2](6bd0ac2))
E85Addict pushed a commit to E85Addict/revanced-integrations that referenced this pull request May 21, 2024
# [1.9.0](v1.8.0...v1.9.0) (2024-05-21)

### Bug Fixes

* Use Java instead of Kotlin Regex to improve reliability ([ReVanced#628](https://github.com/E85Addict/revanced-integrations/issues/628)) ([44c3cc4](44c3cc4))
* **YouTube - Client spoof:** Spoof client to fix playback ([ReVanced#637](https://github.com/E85Addict/revanced-integrations/issues/637)) ([4c1f82a](4c1f82a))
* **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([75fa579](75fa579))
* **YouTube - Hide Shorts components:** Hide old layout like/dislike buttons without leaving empty space ([9782338](9782338))
* **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([ReVanced#625](https://github.com/E85Addict/revanced-integrations/issues/625)) ([656ca17](656ca17))
* **YouTube - Hide video action buttons:** Remove obsolete `hide Shop button` ([ReVanced#618](https://github.com/E85Addict/revanced-integrations/issues/618)) ([a78c3ff](a78c3ff))
* **YouTube - Hide video action buttons:** Updated path filter ([b74e544](b74e544))
* **YouTube - Player flyout menu:** Remove obsolete `Hide report menu` ([9e9d969](9e9d969))
* **YouTube - Restore old video quality menu:** Do not make click sounds when opening Shorts quality menu ([578a27d](578a27d))
* **YouTube - Restore old video quality menu:** Show advanced quality menu in Shorts quality flyout ([ReVanced#632](https://github.com/E85Addict/revanced-integrations/issues/632)) ([77c9825](77c9825))
* **YouTube - Settings:** Use same background color for about screen if Theme patch is not included ([4164ed3](4164ed3))
* **YouTube - SponsorBlock:** Show correct segment times if video is over 24 hours in length ([ReVanced#630](https://github.com/E85Addict/revanced-integrations/issues/630)) ([81251f9](81251f9))

### Features

* **YouTube - Comments:** Add option to hide timestamp and emoji buttons ([ReVanced#621](https://github.com/E85Addict/revanced-integrations/issues/621)) ([6e9e122](6e9e122))
* **YouTube - Hide ads:** Add option to hide the 'Visit store' button on channel pages ([ReVanced#622](https://github.com/E85Addict/revanced-integrations/issues/622)) ([9de566c](9de566c))
* **YouTube - Hide Shorts components:** Hide 'Buy super thanks' button ([ReVanced#633](https://github.com/E85Addict/revanced-integrations/issues/633)) ([303754c](303754c))
* **YouTube - Hide Shorts components:** Hide like / dislike button in video ads ([ReVanced#619](https://github.com/E85Addict/revanced-integrations/issues/619)) ([b2b6b8c](b2b6b8c))
* **YouTube - Navigation buttons:** Add option to hide navigation button labels ([ReVanced#635](https://github.com/E85Addict/revanced-integrations/issues/635)) ([6bd0ac2](6bd0ac2))

### Performance Improvements

* Add upstream sync ([df18a17](df18a17))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants