feat(YouTube): add Player Flyout Menu patch
#416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
reviewed
May 28, 2023
app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java
Outdated
Show resolved
Hide resolved
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
oSumAtrIX
reviewed
May 31, 2023
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
|
I have left some refactoring changes. Is this PR adequately tested? It looks like the exceptions may not be sufficient. Please check for false positives. |
oSumAtrIX
reviewed
May 31, 2023
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
force-pushed
the
dev
branch
2 times, most recently
from
a7bb25c
to
d792b97
Compare
oSumAtrIX
reviewed
Jun 1, 2023
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Jun 1, 2023
app/src/main/java/app/revanced/integrations/patches/components/PlayerFlyoutMenuItemsFilter.java
Outdated
Show resolved
Hide resolved
|
Should I add a check for |
|
Why? |
|
To prevent any false positives. |
oSumAtrIX
force-pushed
the
player-flyout-panel
branch
from
065269b
to
41c8c40
Compare
oSumAtrIX
reviewed
Jun 14, 2023
app/src/main/java/app/revanced/integrations/patches/components/HidePlayerFlyoutMenuFilter.java
Outdated
Show resolved
Hide resolved
…-flyout-panel # Conflicts: # app/src/main/java/app/revanced/integrations/patches/components/LithoFilterPatch.java
johnconner122
changed the title
player-flyout-menu-panel patchplayer-flyout-menu patch
oSumAtrIX
changed the title
player-flyout-menu patchPlayer Flyout Menu patch
app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
approved these changes
Jul 29, 2023
revanced-bot
pushed a commit
that referenced
this pull request
Jul 30, 2023
# [0.115.0-dev.4](v0.115.0-dev.3...v0.115.0-dev.4) (2023-07-30) ### Features * **YouTube:** add `Player Flyout Menu` patch ([#416](#416)) ([b2085ae](b2085ae))
revanced-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [0.115.0](v0.114.0...v0.115.0) (2023-08-02) ### Bug Fixes * **YouTube - SponsorBlock:** Fix skip highlight button showing when set to 'show in seekbar' ([ea7bc57](ea7bc57)) * **YouTube - Spoof App Version:** Remove 17.30.35 target ([e906c6d](e906c6d)) * **YouTube:** fix potential litho filter thread race ([d3f523f](d3f523f)) ### Features * **Tiktok - Feed filter:** Add more filters ([#445](#445)) ([c16c038](c16c038)) * **YouTube - Hide layout components:** Hide `chips shelf` ([#448](#448)) ([c7d2a9b](c7d2a9b)) * **YouTube:** add `Player Flyout Menu` patch ([#416](#416)) ([b2085ae](b2085ae)) ### Performance Improvements * **YouTube:** Filter litho components using prefix tree ([#447](#447)) ([18f2900](18f2900))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
TODO:
commentsfilter to exceptions. These 3 comments' filters are hidden.unintended consequences.