refactor: move settings to SettingsEnum class

[TheJeterLP]

See #37

[ghost]

Based on @oSumAtrIX decision, this litho block should be removed because it disable comments (even if I would like it to keep):

private static boolean isExperimentalCommentsRemoval() {
        return getBoolean("experimental_comments", false);
}

[oSumAtrIX]

No, it should not be removed.

[TheJeterLP]

Based on @oSumAtrIX decision, this litho block should be removed because it disable comments (even if I would like it to keep it):

private static boolean isExperimentalCommentsRemoval() {
        return getBoolean("experimental_comments", false);
}

Makes no sense to remove a feature when theres a setting for it to toggle it.

[ghost]

Makes no sense to remove a feature when theres a setting for it to toggle it.

I agree. Maybe he re-evaluated his decision.

[oSumAtrIX]

But I never said to remove it

[ghost]

But I never said to remove it

Troll?

[oSumAtrIX]

The image is out of context. This was my next response (missing the "not" in the sentence):

[ghost]

The image is out of context. This was my next response (missing the "not" in the sentence):

Sorry, I hadn't paid attention to this comment.👍

Anyway, to close this OT, I'll push some other stuff to hide other comments.

[oSumAtrIX]

Create a patch suggestion on the ReVanced organization discussion page, and see if people need it, before adding it. If you insist, simply make it optional and disabled by default.

[ghost]

Create a patch suggestion on the ReVanced organization discussion page, and see if people need it, before adding it. If you insist, simply make it optional and disabled by default.

Again sorry.

[oSumAtrIX]

Create a patch suggestion on the ReVanced organization discussion page, and see if people need it, before adding it. If you insist, simply make it optional and disabled by default.

Again sorry.

No worries :) Thanks for contributing!