-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move settings to SettingsEnum #49
Conversation
@TheJeterLP why you add "text_display_ad_with_themed_cta_banner_image"? It should be already blocked by "ad_" generic reference (placed at the top of list). It's checked by a contains istruction, should be good already. 🤷♂️ |
Was just for debugging. Forgot to remove it from commit. |
Anyway...have you understand how to block new elements? Was not much difficult at the end xD. |
Yes, also implemented a log for that. |
Good. This will be useful for future (eventually) new ads. 👍 |
🎉 This PR is included in version 0.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
See #37