fix(ui): adjust showSourcesDialog scroll clipping in AlertDialog

This commit resolves the issue of children clipping in `AlertDialog` for the `showSourcesDialog` by adjusting the structure to manage scrolling behavior more efficiently. By doing this, the user experience and readability is greatly improved on small devices and/or devices with large fonts. - Remove child SingleChildScrollView - Add parent (dialog) scrollable property to true
ReVanced · Mar 23, 2024 · 22272c3 · 22272c3
1 parent a71a930
commit 22272c3
Showing 1 changed file with 60 additions and 61 deletions.
diff --git a/lib/ui/views/settings/settingsFragment/settings_manage_sources.dart b/lib/ui/views/settings/settingsFragment/settings_manage_sources.dart
@@ -27,6 +27,7 @@ class SManageSources extends BaseViewModel {
     return showDialog(
       context: context,
       builder: (context) => AlertDialog(
+        scrollable: true,
         title: Row(
           children: <Widget>[
             Text(t.settingsView.sourcesLabel),
@@ -38,75 +39,73 @@ class SManageSources extends BaseViewModel {
             ),
           ],
         ),
-        content: SingleChildScrollView(
-          child: Column(
-            children: <Widget>[
-              TextField(
-                controller: _orgPatSourceController,
-                autocorrect: false,
-                onChanged: (value) => notifyListeners(),
-                decoration: InputDecoration(
-                  icon: Icon(
-                    Icons.extension_outlined,
-                    color: Theme.of(context).colorScheme.onSurfaceVariant,
-                  ),
-                  border: const OutlineInputBorder(),
-                  labelText: t.settingsView.orgPatchesLabel,
-                  hintText: patchesRepo.split('/')[0],
+        content: Column(
+          children: <Widget>[
+            TextField(
+              controller: _orgPatSourceController,
+              autocorrect: false,
+              onChanged: (value) => notifyListeners(),
+              decoration: InputDecoration(
+                icon: Icon(
+                  Icons.extension_outlined,
+                  color: Theme.of(context).colorScheme.onSurfaceVariant,
                 ),
+                border: const OutlineInputBorder(),
+                labelText: t.settingsView.orgPatchesLabel,
+                hintText: patchesRepo.split('/')[0],
               ),
-              const SizedBox(height: 8),
-              // Patches repository's name
-              TextField(
-                controller: _patSourceController,
-                autocorrect: false,
-                onChanged: (value) => notifyListeners(),
-                decoration: InputDecoration(
-                  icon: const Icon(
-                    Icons.extension_outlined,
-                    color: Colors.transparent,
-                  ),
-                  border: const OutlineInputBorder(),
-                  labelText: t.settingsView.sourcesPatchesLabel,
-                  hintText: patchesRepo.split('/')[1],
+            ),
+            const SizedBox(height: 8),
+            // Patches repository's name
+            TextField(
+              controller: _patSourceController,
+              autocorrect: false,
+              onChanged: (value) => notifyListeners(),
+              decoration: InputDecoration(
+                icon: const Icon(
+                  Icons.extension_outlined,
+                  color: Colors.transparent,
                 ),
+                border: const OutlineInputBorder(),
+                labelText: t.settingsView.sourcesPatchesLabel,
+                hintText: patchesRepo.split('/')[1],
               ),
-              const SizedBox(height: 8),
-              // Integrations owner's name
-              TextField(
-                controller: _orgIntSourceController,
-                autocorrect: false,
-                onChanged: (value) => notifyListeners(),
-                decoration: InputDecoration(
-                  icon: Icon(
-                    Icons.merge_outlined,
-                    color: Theme.of(context).colorScheme.onSurfaceVariant,
-                  ),
-                  border: const OutlineInputBorder(),
-                  labelText: t.settingsView.orgIntegrationsLabel,
-                  hintText: integrationsRepo.split('/')[0],
+            ),
+            const SizedBox(height: 8),
+            // Integrations owner's name
+            TextField(
+              controller: _orgIntSourceController,
+              autocorrect: false,
+              onChanged: (value) => notifyListeners(),
+              decoration: InputDecoration(
+                icon: Icon(
+                  Icons.merge_outlined,
+                  color: Theme.of(context).colorScheme.onSurfaceVariant,
                 ),
+                border: const OutlineInputBorder(),
+                labelText: t.settingsView.orgIntegrationsLabel,
+                hintText: integrationsRepo.split('/')[0],
               ),
-              const SizedBox(height: 8),
-              // Integrations repository's name
-              TextField(
-                controller: _intSourceController,
-                autocorrect: false,
-                onChanged: (value) => notifyListeners(),
-                decoration: InputDecoration(
-                  icon: const Icon(
-                    Icons.merge_outlined,
-                    color: Colors.transparent,
-                  ),
-                  border: const OutlineInputBorder(),
-                  labelText: t.settingsView.sourcesIntegrationsLabel,
-                  hintText: integrationsRepo.split('/')[1],
+            ),
+            const SizedBox(height: 8),
+            // Integrations repository's name
+            TextField(
+              controller: _intSourceController,
+              autocorrect: false,
+              onChanged: (value) => notifyListeners(),
+              decoration: InputDecoration(
+                icon: const Icon(
+                  Icons.merge_outlined,
+                  color: Colors.transparent,
                 ),
+                border: const OutlineInputBorder(),
+                labelText: t.settingsView.sourcesIntegrationsLabel,
+                hintText: integrationsRepo.split('/')[1],
               ),
-              const SizedBox(height: 20),
-              Text(t.settingsView.sourcesUpdateNote),
-            ],
-          ),
+            ),
+            const SizedBox(height: 20),
+            Text(t.settingsView.sourcesUpdateNote),
+          ],
         ),
         actions: <Widget>[
           TextButton(