fix: Stop patch when signing fails

[kitadai31]

fix #1253

Currently, even if an error occurred while signing apk, the patching process appears as if it is completed.
Therefore, the patched APK (out.apk) was not actually output, and the [Export APK] button causes a crash.

09-09 13:33:45.253 10011 10011 E AndroidRuntime: java.io.FileNotFoundException: /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-AXYSFX/out.apk: open failed: ENOENT (No such file or directory)

This issue (#1253) is caused by the double nested try block.
Any exceptions that occur while signing apk will be ignored by the try block.
Only a stack trace is output to logcat, but user will have never seen it.

--------- beginning of main
09-09 13:33:41.059 10011 12502 W System.err: java.security.UnrecoverableKeyException: no match
09-09 13:33:41.059 10011 12502 W System.err: 	at com.android.org.bouncycastle.jcajce.provider.keystore.bc.BcKeyStoreSpi$StoreEntry.getObject(BcKeyStoreSpi.java:325)
09-09 13:33:41.059 10011 12502 W System.err: 	at com.android.org.bouncycastle.jcajce.provider.keystore.bc.BcKeyStoreSpi.engineGetKey(BcKeyStoreSpi.java:620)
09-09 13:33:41.059 10011 12502 W System.err: 	at java.security.KeyStore.getKey(KeyStore.java:1062)
09-09 13:33:41.059 10011 12502 W System.err: 	at app.revanced.manager.flutter.utils.signing.Signer.signApk(Signer.kt:63)
09-09 13:33:41.059 10011 12502 W System.err: 	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$13(MainActivity.kt:279)
09-09 13:33:41.059 10011 12502 W System.err: 	at app.revanced.manager.flutter.MainActivity.$r8$lambda$6dokpIuPm1kqn7qLA9JtiVzSCi0(Unknown Source:0)
09-09 13:33:41.059 10011 12502 W System.err: 	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda3.run(Unknown Source:24)
09-09 13:33:41.059 10011 12502 W System.err: 	at java.lang.Thread.run(Thread.java:929)

(quoted from #1253)

This PR removes this double try block to abort patching process properly.

Example

When user entered an incorrect keystore password, UnrecoverableKeyException occurs.
This PR prevents this exception from being ignored.

Screenshot

[oSumAtrIX]

Why not instead simply return after the stack trace is printed? Also when would you expect an error here?

[kitadai31]

Why not instead simply return after the stack trace is printed?

But I think, if an exception is occurred, the exception should be handled at this catch block:

revanced-manager/android/app/src/main/kotlin/app/revanced/manager/flutter/MainActivity.kt

Lines 396 to 405 in a9878db

	} catch (ex: Throwable) {
	if (!cancel) {
	val stack = ex.stackTraceToString()
	updateProgress(
	-100.0,
	"Failed",
	"An error occurred:\n$stack"
	)
	}
	}

Looking at other parts of the method, I don't see any exception handling code.

Also when would you expect an error here?

If user entered an incorrect password

Screenshot

If user imported a keystore generated by Android Studio

Screenshot

(These screenshots are from this PR code)

[kitadai31]

Currently the stack trace is printed using print(), but this only outputs to stdout and does not appear on the screen.
So user can't see the error.
This problem can be seen in the screen recording at #1253.

[kitadai31]

I made the PR description more specific.
Please refer to it whenever you review.