Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow changing languages #1488

Merged
merged 50 commits into from
Feb 11, 2024
Merged

feat: Allow changing languages #1488

merged 50 commits into from
Feb 11, 2024

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Nov 11, 2023 •
edited by validcube

  • Update the branches in the workflow file
  • Translation file post-processor to remove empty strings
  • Look into build errors

@Ushie Ushie force-pushed the feat/i10n branch 2 times, most recently from 7c9390f to 487fcc0 Compare November 11, 2023 18:05
@Ushie Ushie changed the title feat: Allow changing languages (#1450) feat: Allow changing languages Nov 11, 2023
@validcube validcube mentioned this pull request Nov 17, 2023
Merged
8 tasks
@Ushie Ushie linked an issue Nov 19, 2023 that may be closed by this pull request
feat: Use Application Resource Bundle instead of JSON for Localizations #558
Open
4 tasks
@oSumAtrIX
Copy link
Member

Whats the state of this PR?

@validcube
Copy link
Member

Whats the state of this PR?

This PR should be ready (aside from fixing conflicts)

But I'm waiting on review because this is a really big changes.

@validcube
Copy link
Member

@PalmDevs if would like to change some strings, now would be a perfect time to do so.

@Ushie
Copy link
Member Author

Ushie commented Jan 27, 2024

Updating strings is out of scope

@validcube
Copy link
Member

validcube commented Feb 2, 2024 •
edited

String updated to matched with edc8ef4

validcube
validcube reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ireallyhopethiswork

.github/workflows/sync-crowdin.yml Outdated Show resolved Hide resolved
.github/workflows/sync-crowdin.yml Outdated Show resolved Hide resolved
validcube
validcube approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greenlight to review

.github/workflows/sync-crowdin.yml Outdated Show resolved Hide resolved
@Ushie Ushie merged commit f82c439 into dev Feb 11, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
@semantic-release-bot
chore(release): 1.19.0-dev.8 [skip ci]
bdfeda2 
## Features
* Allow changing languages (#1488) ([Ushie](f82c439))
## Chores
* **i18n:** Sync translations (#1671) ([github-actions[bot]](f5578b0))
* update dependencies ([Benjamin Halko](1aaeac1))
@oSumAtrIX oSumAtrIX deleted the feat/i10n branch February 26, 2024 01:59
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
97d8519 
# [1.19.0](v1.18.0...v1.19.0) (2024-03-05)

### Bug Fixes

* added a trailing comma ([975180b](975180b))
* adjust padding ([3559477](3559477))
* Allow mounting without Magisk ([3f96608](3f96608))
* Bump dependencies to support BCS keystore ([6ec6546](6ec6546))
* Do not delete files from post-fs-data.d ([70a1086](70a1086))
* Fix patched APKs exports after installation ([1200360](1200360))
* fix redundant buttons on dialog ([079c0de](079c0de))
* Incorrect strings and logics ([#1619](#1619)) ([4f22e88](4f22e88))
* **Keystore Password:** textfield title display ([8e52abd](8e52abd))
* Mount script causes build to fail ([#1613](#1613)) ([f3c78c2](f3c78c2))
* **Patch Option:** Set text colour on dropdown menu ([acb1e24](acb1e24))
* **PopScope:** User able to exit patch screen when the installer is still running ([#1663](#1663)) ([eb6d3cd](eb6d3cd))
* **Release CI:** truncate the "v" from version ([8595099](8595099))
* Show version label correctly ([c72d10a](c72d10a))
* Specify that dark theme is dark ([#1699](#1699)) ([d4b15ae](d4b15ae))
* Stop patch when signing fails ([#1553](#1553)) ([5b2c551](5b2c551))
* **Update Confirmation Sheet:** Add top padding ([9aeb156](9aeb156))
* Use correct title size for bottom sheet ([#1687](#1687)) ([3436523](3436523))
* Use correct version code & name ([#1647](#1647)) ([d933997](d933997))
* use lowercase repo names ([#1626](#1626)) ([edd8602](edd8602))

### Features

* Add a toggle for alternative sources ([#1686](#1686)) ([f89c742](f89c742))
* Add API migration code ([#1615](#1615)) ([28ae276](28ae276))
* add haptic feedback ([#1459](#1459)) ([7911459](7911459))
* Allow changing languages ([#1488](#1488)) ([f82c439](f82c439))
* Display current app language at the top of the list ([aa0575a](aa0575a))
* Hide the Install button during installation ([#1633](#1633)) ([3e696d6](3e696d6))
* Improve app selector and patcher UI ([#1616](#1616)) ([efb2d5e](efb2d5e))
* Improve consistency on language selector ([b2119ce](b2119ce))
* Improve language distinguishness and resolve language-specific issues ([#1706](#1706)) ([6d866d4](6d866d4))
* Improve Split APK warning readability ([#1625](#1625)) ([6fd740f](6fd740f))
* Show a dialog when an update is available ([#1654](#1654)) ([c7d975e](c7d975e))
* Simplify settings strings ([#1618](#1618)) ([0d45fe4](0d45fe4))
* Use more appropriate progress values ([2d7026a](2d7026a))
* use native TextField ([9ed43ef](9ed43ef))

### Performance Improvements

* Load patched apps as soon as possible ([c94eb7a](c94eb7a))

### Reverts

* WillPopScope migration ([3b0fed5](3b0fed5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube approved these changes

Assignees

@validcube validcube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Use Application Resource Bundle instead of JSON for Localizations Addition of Japanese translation
4 participants
@Ushie @validcube @oSumAtrIX @crowdin-bot