New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PopScope): User able to exit patch screen when the installer is still running #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please rebase this on the latest commit. |
BenjaminHalko
force-pushed
the
fix/pop-scope
branch
from
February 1, 2024 17:10
21ae158
to
a56a699
Compare
validcube
reviewed
Feb 2, 2024
validcube
changed the title
fix: Patch screen PopScope
fix(PopScope): User able to exit patch screen when the installer is still running
Feb 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
# [1.19.0](v1.18.0...v1.19.0) (2024-03-05) ### Bug Fixes * added a trailing comma ([975180b](975180b)) * adjust padding ([3559477](3559477)) * Allow mounting without Magisk ([3f96608](3f96608)) * Bump dependencies to support BCS keystore ([6ec6546](6ec6546)) * Do not delete files from post-fs-data.d ([70a1086](70a1086)) * Fix patched APKs exports after installation ([1200360](1200360)) * fix redundant buttons on dialog ([079c0de](079c0de)) * Incorrect strings and logics ([#1619](#1619)) ([4f22e88](4f22e88)) * **Keystore Password:** textfield title display ([8e52abd](8e52abd)) * Mount script causes build to fail ([#1613](#1613)) ([f3c78c2](f3c78c2)) * **Patch Option:** Set text colour on dropdown menu ([acb1e24](acb1e24)) * **PopScope:** User able to exit patch screen when the installer is still running ([#1663](#1663)) ([eb6d3cd](eb6d3cd)) * **Release CI:** truncate the "v" from version ([8595099](8595099)) * Show version label correctly ([c72d10a](c72d10a)) * Specify that dark theme is dark ([#1699](#1699)) ([d4b15ae](d4b15ae)) * Stop patch when signing fails ([#1553](#1553)) ([5b2c551](5b2c551)) * **Update Confirmation Sheet:** Add top padding ([9aeb156](9aeb156)) * Use correct title size for bottom sheet ([#1687](#1687)) ([3436523](3436523)) * Use correct version code & name ([#1647](#1647)) ([d933997](d933997)) * use lowercase repo names ([#1626](#1626)) ([edd8602](edd8602)) ### Features * Add a toggle for alternative sources ([#1686](#1686)) ([f89c742](f89c742)) * Add API migration code ([#1615](#1615)) ([28ae276](28ae276)) * add haptic feedback ([#1459](#1459)) ([7911459](7911459)) * Allow changing languages ([#1488](#1488)) ([f82c439](f82c439)) * Display current app language at the top of the list ([aa0575a](aa0575a)) * Hide the Install button during installation ([#1633](#1633)) ([3e696d6](3e696d6)) * Improve app selector and patcher UI ([#1616](#1616)) ([efb2d5e](efb2d5e)) * Improve consistency on language selector ([b2119ce](b2119ce)) * Improve language distinguishness and resolve language-specific issues ([#1706](#1706)) ([6d866d4](6d866d4)) * Improve Split APK warning readability ([#1625](#1625)) ([6fd740f](6fd740f)) * Show a dialog when an update is available ([#1654](#1654)) ([c7d975e](c7d975e)) * Simplify settings strings ([#1618](#1618)) ([0d45fe4](0d45fe4)) * Use more appropriate progress values ([2d7026a](2d7026a)) * use native TextField ([9ed43ef](9ed43ef)) ### Performance Improvements * Load patched apps as soon as possible ([c94eb7a](c94eb7a)) ### Reverts * WillPopScope migration ([3b0fed5](3b0fed5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1645