feat: Add ability to set null in patch options
#1947
Merged
+153
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
validcube
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
🥞 Approved, thanks!
Compiled using Flutter 3.23.0-0.1.pre (Beta) and tested on physical devices running Android 14 (Samsung One UI 6.1 - 1st May)
Test result (🥞 Passed)
- Application: YouTube v19.16.39 - Custom Branding
- Null value provided to "App name" option: ✅ (Should stay "YouTube" since we don't change anything)
- "YT ReVanced" provided to "App name" option: ✅ (The application should be "YT ReVanced" as provided)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
# [1.21.0-dev.4](v1.21.0-dev.3...v1.21.0-dev.4) (2024-06-24) ### Bug Fixes * Cache external API calls ([#1911](#1911)) ([2c3e2e6](2c3e2e6)) * Follow language update immediately ([#1944](#1944)) ([c13827e](c13827e)) * SecurityException when patching application ([#1856](#1856)) ([e0a6de2](e0a6de2)) * Update dialog shows dev version & loading gets stuck in certain circumstances ([#1792](#1792)) ([fc52560](fc52560)) ### Features * Add ability to set `null` in patch options ([#1947](#1947)) ([5c68d51](5c68d51))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
# [1.21.0](v1.20.1...v1.21.0) (2024-07-29) ### Bug Fixes * Add missing import to patch options field ([d60f9aa](d60f9aa)) * Adjust scroll from clipping children form fields in `AlertDialog` from `showSourcesDialog` ([#1782](#1782)) ([bbeb836](bbeb836)) * Cache external API calls ([#1911](#1911)) ([2c3e2e6](2c3e2e6)) * Change problematic translation string ([6b03f3a](6b03f3a)) * Correct architecture to armeabi-v7a ([63c6412](63c6412)) * Download latest integrations non-pre-release ([4a72267](4a72267)) * Follow language update immediately ([#1944](#1944)) ([c13827e](c13827e)) * Follow system theme immediately ([#1942](#1942)) ([694f2a9](694f2a9)) * Handle selecting files and folders for patch options correctly ([#1941](#1941)) ([b26760b](b26760b)) * Increase dashboard RefreshIndicator edge offset ([#1859](#1859)) ([232b702](232b702)) * Patching Screen draw-behind Navigation Bar ([#1945](#1945)) ([f1b25d0](f1b25d0)) * Restore consistency with the app ([ea9654e](ea9654e)) * SecurityException when patching application ([#1856](#1856)) ([e0a6de2](e0a6de2)) * Select previously applied patches when loading patch selection ([#1865](#1865)) ([7ef8f04](7ef8f04)) * Unable to install application regardless of preference ([c7627ce](c7627ce)) * Unsupported patch toast says "patchItem.unsupportedPatchVersion" ([#2011](#2011)) ([3209c0e](3209c0e)) * Update dialog shows dev version & loading gets stuck in certain circumstances ([#1792](#1792)) ([fc52560](fc52560)) ### Features * Add ability to set `null` in patch options ([#1947](#1947)) ([5c68d51](5c68d51)) * Include primary architecture in external search ([#2068](#2068)) ([23690a9](23690a9)) * open browser when clicking on changelog link ([bc300d8](bc300d8)) * Save last patched app ([#1414](#1414)) ([7720408](7720408)) * Support patching on ARMv7a ([a766352](a766352))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screenshots
