Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cache external API calls #1911

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: Cache external API calls #1911

merged 1 commit into from
May 18, 2024

Conversation

kitadai31
Copy link
Contributor

@kitadai31 kitadai31 commented May 18, 2024 •
edited

#1776 (comment)

Make github_api to use Lock (synchronized) like revanced_api
This reduces GitHub API rate limit exceedance.

@oSumAtrIX oSumAtrIX changed the title fix(GitHub API): Unnecessary requests are sent due to a caching issue fix: Cache external API calls May 18, 2024
BenjaminHalko
BenjaminHalko approved these changes May 18, 2024
View reviewed changes
Copy link
Sponsor Member

@BenjaminHalko BenjaminHalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@BenjaminHalko BenjaminHalko merged commit 2c3e2e6 into ReVanced:dev May 18, 2024
1 check passed
@kitadai31 kitadai31 deleted the fix/github-api-overaccesses branch May 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminHalko BenjaminHalko BenjaminHalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kitadai31 @BenjaminHalko