Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Odd usage of icon for API URL popup #1972

Closed
4 tasks done
oSumAtrIX opened this issue Jun 22, 2024 · 4 comments · Fixed by #2033
Closed
4 tasks done

bug: Odd usage of icon for API URL popup #1972

oSumAtrIX opened this issue Jun 22, 2024 · 4 comments · Fixed by #2033
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jun 22, 2024

Bug description

A better icon should be used as the current one does not properly convey the semantics, maybe the wifi icon:

image

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager
@oSumAtrIX oSumAtrIX added Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Jun 22, 2024
@Axelen123
Copy link
Member

Why would the Wi-Fi Icon be better here? Please elaborate

@validcube
Copy link
Member

Wi-Fi icon is universally recognised as basically the internet, I believe the correct icon should be the API icon from Material Symbol

https://fonts.google.com/icons?selected=Material+Symbols+Outlined:api:FILL@0;wght@400;GRAD@0;opsz@24&icon.size=24&icon.color=%235f6368

@oSumAtrIX
Copy link
Member Author

I think semantics is correct here as well. Abusing another icon that is supposed to mean something different is probably not a good idea. The correct approach I suppose would be to suggest changes to the API icon

@Ushie
Copy link
Member

Ushie commented Jul 2, 2024

Closing as out of scope

@Ushie Ushie closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@Ushie Ushie reopened this Jul 2, 2024
Ushie added a commit that referenced this issue Jul 2, 2024
@Ushie Ushie closed this as completed Jul 2, 2024
@validcube validcube linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants