Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fixed): replaced some emoji icons, not rendering on chromium based browsers on windows #1123

Merged
merged 1 commit into from
Aug 11, 2023
Merged

docs(fixed): replaced some emoji icons, not rendering on chromium based browsers on windows #1123

merged 1 commit into from
Aug 11, 2023

Conversation

neosubhamoy
Copy link
Contributor

improved overall docs appearance

@PalmDevs
Copy link
Member

What's the difference between this change and the current documentation? Can you post screenshots?

@validcube
Copy link
Member

I cannot confirm this on Windows 11 (23H3), Edge 115 & Chrome 118, The emoji looks fine to me,

image

@validcube validcube added the Waiting on author Further information is requested label Aug 10, 2023
@neosubhamoy
Copy link
Contributor Author

Apologise! for the confusion...!! Actually, the problem is not with Windows11(Any Version). it's only happening on the latest Windows10 (22H2) and older versions. Tested on latest versions of: Chrome, Edge & Brave (Firefox doesn't have any issues as it uses its own emoji rendering system)
The problem is Windows10 has horrible emoji Unicode support (Does not have support for the new Screwdriver, Ladder, etc. emojis)

Take a look at these screenshots below:

revanced-managerdocs1_installation md at main · ReVancedrevanced-manager
revanced-managerdocs2_1_patching md at main · ReVancedrevanced-manager
revanced-managerdocsREADME md at main · ReVancedrevanced-manager (1)

Hope you got the point...!!

@validcube validcube removed the Waiting on author Further information is requested label Aug 10, 2023
@validcube
Copy link
Member

Thoughts? @Ushie @oSumAtrIX

validcube
validcube approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫 Changes approved!

I can also confirm this on Windows 10

@taku-nm
Copy link
Contributor

taku-nm commented Aug 11, 2023

Can confirm. I have noticed this issue before but didn't think much of it. Win10 22H2

@validcube validcube changed the base branch from main to dev August 11, 2023 03:17
@validcube validcube merged commit 94acebb into ReVanced:dev Aug 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neosubhamoy @PalmDevs @validcube @taku-nm