ci: build pull requests

[BenjaminHalko]

This should hopefully allow compose-dev pr's to build the manager. (Though I haven't been able to test it much)

This is a combination of flutter pr build and compose release.

This workflow is not for building & uploading to GitHub releases, it is meant for building/verifying compose pull requests.

[validcube]

I have no objections, would anyone from team like to comment on this?

[oSumAtrIX]

This duplicates an existing workflow in the wrong branch. The PR target should be the compose branch and it should replace an existing release workflow if there is any

[Ushie]

The workflow will not run if it doesn't reach the main (dev), it can't simply stay in the compose-dev branch

[BenjaminHalko]

This workflow is meant to mimic the pr-build workflow for Flutter / the release workflow (without the push trigger) that was for compose on the previous repo and should be merged with main so that it triggers on pull requests for compose so that it can verify that the pr compiles / can be easily downloadable for testing purposes.

#1235 is the potential release workflow for compose that will stay on compose-dev until compose-dev is merged with main.

[oSumAtrIX]

Apparently, the workflow should also run if not on the main or dev branch, so it should be introduced with the compose branch if it is meant to create compose releases.

[BenjaminHalko]

@oSumAtrIX If I were to switch the branch to compose-dev would I need to create a separate pull request? As this on targets dev and switching the branch inside the pr seems to create conflicts (unless I am just doing it wrong).

[oSumAtrIX]

The conflicts happen because your source branch is based on the current dev branch. If you simply cherry pick your commits on top of the compose branch and force push it to the PRs source branch, this should solve the merge conflicts when you change the target to the compose branch

[oSumAtrIX]

Currently, there is a workflow present in the compose-dev branch, but it does not run @PalmDevs may know more about this.

[Ushie]

Apparently, the workflow should also run if not on the main or dev branch, so it should be introduced with the compose branch if it is meant to create compose releases.

It simply uploads the build as an artifact in Actions, it doesn't create a release

[oSumAtrIX]

What do you mean by "it"? The workflow introduced by this PR or the existing one in the compose dev branch?

[Ushie]

The one introduced by this PR

[oSumAtrIX]

Sounds good, changing the target branch should be enough then.

[BenjaminHalko]

@oSumAtrIX done

[BenjaminHalko]

@Ushie I did some tests and for pull request workflows, it seems like the workflow has to be in the branch getting merged.

Example:

• branch a has the workflow pr-build.yml.
• branch b has the workflow pr-build-b.yml
• if the pr targets branch a, pr-build.yml will trigger
• if the pr targets branch b, pr-build-b.yml will trigger
• if the pr targets branch c (which has no pull request workflows), nothing will happen.

[Ushie]

It seems like what I said wasn't true, I'm not sure why I was strongly under the assumption that workflows are only recognised in the default branch, my comments can be ignored

[BenjaminHalko]

@Ushie No worries!
@oSumAtrIX Is this ready to merge now?

[BenjaminHalko]

Like this?

path: |
            ${{ runner.home }}/.gradle/caches
            ${{ runner.home }}/.gradle/wrapper
            .gradle
          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}

[BenjaminHalko]

should it also be hashing other gradle files like settings.gradle.kts and build.gradle.kts?

[BenjaminHalko]

Like this:

path: |
            ${{ runner.home }}/.gradle/caches
            ${{ runner.home }}/.gradle/wrapper
            .gradle
          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '*.gradle*') }}

[Ushie]

gradle-wrapper.properties should be kept, I'm not sure if other files are necessary

[BenjaminHalko]

sure, I just found that we do have a gradle-wrapper file. My bad.

[BenjaminHalko]

@oSumAtrIX Is this ready for merge now?

[BenjaminHalko]

@oSumAtrIX Is this ready to merge?

[oSumAtrIX]

You got the greens from me ✅

[BenjaminHalko]

@Ushie Anything else to add?

[BenjaminHalko]

@Ushie done