Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #1247

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: update dependencies #1247

merged 1 commit into from
Sep 15, 2023

Conversation

PatrykMis
Copy link

Replaces ReVanced/revanced-manager-compose#90

Not tested yet, will do it tomorrow.

@PatrykMis PatrykMis mentioned this pull request Sep 7, 2023
Closed
@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Sep 7, 2023
validcube
validcube requested changes Sep 7, 2023
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@validcube validcube self-requested a review September 8, 2023 00:19
validcube
validcube requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon compiling I see error related to androidx.emoji2:emoji2-views-helper:1.4.0 compiled for Android 14, not Android 13.

@PatrykMis
chore: update dependencies
bf9252d 
Signed-off-by: Patryk Mis <foss@patrykmis.com>
Signed-off-by: Patryk Miś <foss@patrykmis.com>
@PatrykMis
Copy link
Author

PatrykMis commented Sep 9, 2023 •
edited
Loading

Ok - fixed, now tested and rebased PR.

@validcube validcube self-requested a review September 10, 2023 02:46
validcube
validcube approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 +1 Approved, Tested on Debug variant of ReVanced Manager Compose

@Axelen123
Copy link
Member

Apologies for the late review

@Axelen123 Axelen123 merged commit fc577b4 into ReVanced:compose-dev Sep 15, 2023
1 check passed
@PatrykMis PatrykMis deleted the deps-230907 branch September 26, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axelen123 Axelen123 Axelen123 approved these changes

@validcube validcube validcube approved these changes

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PatrykMis @Axelen123 @validcube