Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hide the Install button during installation #1633

Merged
merged 10 commits into from
Feb 25, 2024
Merged

feat: Hide the Install button during installation #1633

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb1b0da
chore: merge `dev` to `main` (#1573)
oSumAtrIX Dec 23, 2023
2eaab01
add InstallerViewModel.isInstalling property
erayerdin Jan 11, 2024
2152beb
set isInstalling prop in installResult method
erayerdin Jan 11, 2024
ed2d5b0
separate FloatingActionButton by model.isInstalled
erayerdin Jan 11, 2024
ad86a5d
set isInstalling in installResult
erayerdin Jan 12, 2024
0940d5c
disable install button while installing
erayerdin Jan 12, 2024
07282ce
Merge branch 'dev' into feat/disable-install-button
erayerdin Jan 17, 2024
f74d88e
hide floating action button while installing
erayerdin Feb 5, 2024
ffbdafa
refactor: Minor cleanup
Ushie Feb 25, 2024
5437a74
Merge branch 'dev' into pr/erayerdin/1633
Ushie Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ui/views/installer/installer_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class InstallerView extends StatelessWidget {
floatingActionButton: Visibility(
visible: !model.isPatching && !model.hasErrors,
child: model.isInstalled
? FloatingActionButton.extended(
? HapticFloatingActionButtonExtended(
validcube marked this conversation as resolved.
Show resolved Hide resolved
label: I18nText('installerView.openButton'),
icon: const Icon(Icons.open_in_new),
onPressed: () {
Expand All @@ -35,7 +35,7 @@ class InstallerView extends StatelessWidget {
},
elevation: 0,
)
: FloatingActionButton.extended(
: HapticFloatingActionButtonExtended(
label: I18nText('installerView.installButton'),
icon: const Icon(Icons.file_download_outlined),
onPressed: model.isInstalling
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.