Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct version code & name #1647

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: use correct version code & name #1647

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b043bc1
fix: use correct version code
BenjaminHalko Jan 22, 2024
d0174de
Changed version name
BenjaminHalko Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:

- name: Bump pubspec version
run: |
IFS='.' read -r -a nums <<< "${RELEASE_VERSION/-dev/}.0"
VERSION=$(echo "${RELEASE_VERSION}" | sed 's/v//')
IFS='.' read -r -a nums <<< "${VERSION/-dev/}.0"
VERSIONCODE=$((nums[0] * 100000000 + nums[1] * 100000 + nums[2] * 100 + nums[3]))
sed -i "/^version/c\\version: $VERSION+$VERSIONCODE" pubspec.yaml

Expand All @@ -54,11 +54,6 @@ jobs:
run: dart run build_runner build --delete-conflicting-outputs

- name: Build with Flutter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_KEYSTORE_PASSWORD }}
run: flutter build apk

- name: Sign APK
Expand All @@ -72,7 +67,7 @@ jobs:
keyPassword: ${{ secrets.SIGNING_KEY_PASSWORD }}

- name: Rename APK
run: mv ${{steps.sign_apk.outputs.signedFile}} revanced-manager-v${{ env.RELEASE_VERSION }}.apk
run: mv ${{steps.sign_apk.outputs.signedFile}} revanced-manager-${{ env.RELEASE_VERSION }}.apk

- name: Publish release APK
env:
Expand Down