Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Brazilian Portuguese translations #23

Closed
wants to merge 1 commit into from
Closed

feat: Added Brazilian Portuguese translations #23

wants to merge 1 commit into from

Conversation

alexandreteles
Copy link

@alexandreteles alexandreteles commented Jul 6, 2022

Some considerations:

  1. Strings available on the file sourced from Crowdin and shared as a zip on Discord are unchanged;

  2. New strings are translated in a friendly way, following the spirit of the original translations from Crowdin;

  3. The "ReVanced Manager" name was kept as is (following the dev team guidelines);

  4. File structure is unchanged, although I've added an empty line at the end of the file as per good practices 😽

Some considerations:

1. Strings available on the file sourced from Crowdin and shared as a zip on Discord are unchanged;

2. New strings are translated in a friendly way, following the spirit of the original translations from Crowdin;

3. The "ReVanced Manager" name was kept as is (following the dev team guidelines);

4. File structure is unchanged, although I've added an empty line at the end of the file as per good practices 😙
@alexandreteles
Copy link
Author

Oh, and would be nice to have those translation PRs merged before we have to rebase our changes 😹

@TheJeterLP TheJeterLP added Feature request Requesting a new feature that's not implemented yet translation labels Jul 9, 2022
@Sculas
Copy link
Contributor

Sculas commented Jul 30, 2022

The manager is going to be rewritten, meaning all translations will be invalidated. So I'm going to close this PR. Thank you for your contribution!

@Sculas Sculas closed this Jul 30, 2022
oSumAtrIX pushed a commit that referenced this pull request Aug 26, 2023
oSumAtrIX pushed a commit that referenced this pull request Aug 26, 2023
validcube pushed a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants