Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Dependencies being added to the set of executed patches #300

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Jun 24, 2024 · 6 comments · Fixed by #279
Closed
3 tasks done

bug: Dependencies being added to the set of executed patches #300

ILoveOpenSourceApplications opened this issue Jun 24, 2024 · 6 comments · Fixed by #279
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link

Bug description

Dependencies are being added to the set of executed patches which if closeable are logged: https://github.com/ReVanced/revanced-patcher/blob/main/src/main/kotlin/app/revanced/patcher/Patcher.kt#L252

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Jun 24, 2024
@oSumAtrIX oSumAtrIX linked a pull request Jul 25, 2024 that will close this issue
chore: Merge branch dev to main #279
Merged
@ILoveOpenSourceApplications
Copy link
Author

Hey @oSumAtrIX, I'm still seeing the dependencies while patching now as well.

@oSumAtrIX
Copy link
Member

Did you use the release of Patcher that fixes it

@ILoveOpenSourceApplications
Copy link
Author

The manager fetches the latest release right?

@oSumAtrIX
Copy link
Member

No. It uses the version it was compiled with.

@ILoveOpenSourceApplications
Copy link
Author

I am currently using the latest version of ReVanced Manager, v1.21.2. So when will it be fixed for the manager?

@oSumAtrIX
Copy link
Member

Whenever it uses the release of Patcher that fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Merge branch dev to main ReVanced/revanced-patcher
2 participants
@oSumAtrIX @ILoveOpenSourceApplications