Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compare method fingerprint parameter order #183

Merged
merged 2 commits into from May 30, 2023
Merged

fix: compare method fingerprint parameter order #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a39b3f
parametersEqual ordering
LisoUseInAIKyrios May 28, 2023
302dd46
comments
LisoUseInAIKyrios May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/main/kotlin/app/revanced/patcher/extensions/Extensions.kt
View file
Open in desktop
Expand Up @@ -220,17 +220,15 @@ private fun replaceOffset(
*/
internal fun Method.cloneMutable(registerCount: Int = 0) = clone(registerCount).toMutable()

// FIXME: also check the order of parameters as different order equals different method overload
internal fun parametersEqual(
parameters1: Iterable<CharSequence>, parameters2: Iterable<CharSequence>
): Boolean {
return parameters1.count() == parameters2.count() && parameters1.all { parameter ->
parameters2.any {
it.startsWith(
parameter
)
}
if (parameters1.count() != parameters2.count()) return false
val iterator1 = parameters1.iterator()
parameters2.forEach {
if (!it.startsWith(iterator1.next())) return false
}
return true
}

internal val nullOutputStream = object : OutputStream() {
Expand Down