feat: Read and write arbitrary files in APK files #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows reading and writing arbitrary files in an APK file. Additionally it allows deleting files from APK files. A `RawResourcePatch` class has been added which has access to `ResourceContext` but ReVanced Patcher will not decode APK resources. A regular `ResourcePatch` can read and write arbitrary files from an APK file, unless they are decoded to `PatcherConfig.apkFiles`. On attempt to get a file from `PatcherConfig.apkFiles` if the second parameter is true, it will read and write the raw resource file from the original APK to `PatcherConfig.apkFiles` if it does not exist. With this commit, many APIs have been deprecated as well, such as `DomFileEditor` and instead a `Document` has been added.
Open
oSumAtrIX
commented
Feb 11, 2024
This was referenced Feb 11, 2024
Aunali321
approved these changes
Feb 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR allows reading and writing arbitrary files in an APK file. Additionally, it allows deleting files from APK files. A
RawResourcePatchclass has been added, which has access toResourceContextbut ReVanced Patcher will not decode APK resources. A regularResourcePatchcan read and write arbitrary files from an APK file unless they are decoded toPatcherConfig.apkFiles. On an attempt to get a file fromPatcherConfig.apkFilesif the second parameter is true, it will read and write the raw resource file from the original APK toPatcherConfig.apkFilesif it does not exist. With this commit, many APIs have been deprecated as well, such asDomFileEditorand instead, aDocumenthas been added.