feat(slideforreddit): add change-oauth-client-id patch

[vlemazza]

This patch, like others for the various reddit clients, replace the developer's client id with a personal one.

[oSumAtrIX]

Likely this is the only method that has this name. Is it necessary to check for the classes type?

[LisoUseInAIKyrios]

If the classdef check remains, at least simplify this to:

.customFingerprint = { methodDef, classDef ->
        classDef.type.endsWith("Credentials;")
        && methodDef.name == "getClientId"

[oSumAtrIX]

This is less readable than before

[LisoUseInAIKyrios]

Is it? It's one statement rather than two. Not a concern either way.

[oSumAtrIX]

Consider the following example:

if (!a) return false;
if (b) return false;

return c;

This example is easy to understand and follow. Now try to convert it to a single statement. Already the conversion requires a certain amount of thought to process. The reverse will be required when trying to understand the statement.

I'd use && to prevent nesting for example, or when there is a lot of expressions which you can group together such as:

if (a && b && c && d) return false;

Here, I prefer to seperate the two statements, because the newline before the && causes an indentation, which looks weird. (You forgot an additional indentation in your suggestion):

if (a
    && b) return false;

Indentations are useful to group blocks of code that are semantically related such as an if statements body. Here the indentation makes less sense in this regard. Removing the newline causes the line of code to be very long which is why separating into two expressions is a good solution that is simple to follow and read.

[LisoUseInAIKyrios]

If its an issue with multiple lines it could be:

.customFingerprint = { methodDef, classDef ->
        classDef.type.endsWith("Credentials;") && methodDef.name == "getClientId"

Everything is a true statement, so it's similar to the if (a && b && c && d) return false; you mentioned.

This is a minor detail so it doesn't matter much either way (so long as the code works).

[oSumAtrIX]

If its an issue with multiple lines it could be

Similar lines of code exceed the maximum recommended amount of characters per line, hence auto refactoring will insert the newline back again, but yeah minor problem :)

[oSumAtrIX]

Resolve pending comments, rest lgtm

[vlemazza]

a conflict in the file patches.json needs to be resolved, what is missing ?

[oSumAtrIX]

Simply do not commit to that file

[LisoUseInAIKyrios]

a conflict in the file patches.json needs to be resolved, what is missing ?

You need to revert the commit that edited patches.json

[LisoUseInAIKyrios]

Since the patch changed the string returned from the method, can verify the fingerprint does the same and add:

returnType = "Ljava/lang/String;",

[vlemazza]

You need to revert the commit that edited patches.json

done reverted

[welcome]

Thank you for contributing to ReVanced. Join us on Discord if you want to receive a contributor role.