fix(Reddit is Fun - Spoof client): Fix login by updating the authoriz…

…ation subdomain from "old" to "ssl"
ReVanced · May 6, 2024 · b156cb1 · b156cb1
1 parent a517250
commit b156cb1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/api/revanced-patches.api b/api/revanced-patches.api
@@ -576,6 +576,7 @@ public final class app/revanced/patches/reddit/customclients/joeyforreddit/detec
 public final class app/revanced/patches/reddit/customclients/redditisfun/api/SpoofClientPatch : app/revanced/patches/reddit/customclients/BaseSpoofClientPatch {
 	public static final field INSTANCE Lapp/revanced/patches/reddit/customclients/redditisfun/api/SpoofClientPatch;
 	public fun patchClientId (Ljava/util/Set;Lapp/revanced/patcher/data/BytecodeContext;)V
+	public fun patchMiscellaneous (Ljava/util/Set;Lapp/revanced/patcher/data/BytecodeContext;)V
 	public fun patchUserAgent (Ljava/util/Set;Lapp/revanced/patcher/data/BytecodeContext;)V
 }
 

diff --git a/...main/kotlin/app/revanced/patches/reddit/customclients/redditisfun/api/SpoofClientPatch.kt b/...main/kotlin/app/revanced/patches/reddit/customclients/redditisfun/api/SpoofClientPatch.kt
@@ -10,8 +10,10 @@ import app.revanced.patches.reddit.customclients.BaseSpoofClientPatch
 import app.revanced.patches.reddit.customclients.redditisfun.api.fingerprints.BasicAuthorizationFingerprint
 import app.revanced.patches.reddit.customclients.redditisfun.api.fingerprints.BuildAuthorizationStringFingerprint
 import app.revanced.patches.reddit.customclients.redditisfun.api.fingerprints.GetUserAgentFingerprint
+import app.revanced.util.getReference
+import app.revanced.util.indexOfFirstInstruction
 import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
-
+import com.android.tools.smali.dexlib2.iface.reference.StringReference
 
 @Suppress("unused")
 object SpoofClientPatch : BaseSpoofClientPatch(
@@ -20,8 +22,8 @@ object SpoofClientPatch : BaseSpoofClientPatch(
     userAgentFingerprints = setOf(GetUserAgentFingerprint),
     compatiblePackages = setOf(
         CompatiblePackage("com.andrewshu.android.reddit"),
-        CompatiblePackage("com.andrewshu.android.redditdonation")
-    )
+        CompatiblePackage("com.andrewshu.android.redditdonation"),
+    ),
 ) {
     override fun Set<MethodFingerprintResult>.patchClientId(context: BytecodeContext) {
         /**
@@ -59,7 +61,23 @@ object SpoofClientPatch : BaseSpoofClientPatch(
             """
                 const-string v0, "$userAgent"
                 return-object v0
-            """
+            """,
         )
     }
-}
+
+    override fun Set<MethodFingerprintResult>.patchMiscellaneous(context: BytecodeContext) {
+        // Reddit messed up and does not append a redirect uri to the authorization url to old.reddit.com/login.
+        // Replace old.reddit.com with ssl.reddit.com to fix this.
+        BuildAuthorizationStringFingerprint.result!!.mutableMethod.apply {
+            val index = indexOfFirstInstruction {
+                getReference<StringReference>()?.contains("old.reddit.com") == true
+            }
+
+            val targetRegister = getInstruction<OneRegisterInstruction>(index).registerA
+            replaceInstruction(
+                index,
+                "const-string v$targetRegister, \"https://ssl.reddit.com/api/v1/authorize.compact\"",
+            )
+        }
+    }
+}