Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: selecting text in comment will spawn big white block #1876

Closed
3 tasks done
AMSAMSAMSAMS opened this issue Oct 28, 2022 · 10 comments
Closed
3 tasks done

bug: selecting text in comment will spawn big white block #1876

AMSAMSAMSAMS opened this issue Oct 28, 2022 · 10 comments
Labels
Bug report Something isn't working

Comments

@AMSAMSAMSAMS
Copy link

AMSAMSAMSAMS commented Oct 28, 2022 •
edited by oSumAtrIX

Type

Cosmetic

Bug description

This happened since Vanced era, dunno what caused it.

Steps to reproduce

Just type anything in comment, don't send.
Instead just long press to select & BOOM!

Relevant log output

NO LOG as this is cosmetic.

Screenshots or videos

Screenshot_20221027-172517_YouTube

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@AMSAMSAMSAMS AMSAMSAMSAMS added the Bug report Something isn't working label Oct 28, 2022
@AMSAMSAMSAMS
Copy link
Author

Worse it duplicated on the video section & undismissable....

@ghost
Copy link

ghost commented Oct 28, 2022

Can't be fixed unfortunately.

@oSumAtrIX
Copy link
Member

Can't be fixed unfortunately.

Why?

@oSumAtrIX
Copy link
Member

Did you include the theme patch?

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Oct 28, 2022
@Crescendo-BLYAT
Copy link

Did you include the theme patch?

nope... I excluded theme patch...

@oSumAtrIX
Copy link
Member

This is an issue with your Android OS. Disable it forcing theming on the patched app.

@SodaWithoutSparkles
Copy link
Contributor

I cannot reproduce this

@AMSAMSAMSAMS
Copy link
Author

AMSAMSAMSAMS commented Nov 1, 2022 •
edited

This is an issue with your Android OS. Disable it forcing theming on the patched app.

Samsung S20FE - OneUI 4.1 - Android 12 - not rooted - no OS theme applied.
So I just enable the ReVanced theme to fix it?

EDIT: Nope, ommiting -e theme (thus enabling the default theme) doesn't fix anything.

@anil-al

This comment was marked as spam.

Sign in to view
@oSumAtrIX
Copy link
Member

EDIT: Nope, ommiting -e theme (thus enabling the default theme) doesn't fix anything.

As I said, it is not an issue with ReVanced, you force override dark mode on your device. Disable it for the patched app and it should work.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.169.0-dev.1 [skip ci]
9d0dae0 
# [2.169.0-dev.1](ReVanced/revanced-patches@v2.168.0...v2.169.0-dev.1) (2023-04-21)

### Bug Fixes

* add missing annotation to patches ([ReVanced#1882](ReVanced/revanced-patches#1882)) ([d86b6a4](ReVanced/revanced-patches@b6a7640))
* **youtube/hide-video-action-buttons:** change 'Hide create, clip and thanks buttons' to default off ([ReVanced#1923](ReVanced/revanced-patches#1923)) ([fc89c86](ReVanced/revanced-patches@f007c5e))
* **youtube/hide-video-action-buttons:** fix 'hide share button' ([ReVanced#1924](ReVanced/revanced-patches#1924)) ([bc05e44](ReVanced/revanced-patches@7f518de))
* **youtube/microg-support:** remove incorrect patch dependency ([3e0c45c](ReVanced/revanced-patches@2ec08b3))
* **youtube/microg-support:** rename patch correctly ([091a25d](ReVanced/revanced-patches@3b726f3))
* **youtube/return-youtube-dislike:** render dislikes when scrolling into the screen ([ReVanced#1873](ReVanced/revanced-patches#1873)) ([85675b8](ReVanced/revanced-patches@d9dc58d))
* **youtube/sponsorblock:** do not depend on `remember-playback-speed` patch ([b0834fa](ReVanced/revanced-patches@cbbd6bb))
* **youtube/sponsorblock:** fix autorepeat button layout ([ReVanced#1868](ReVanced/revanced-patches#1868)) ([5e148d9](ReVanced/revanced-patches@ddee5f0))
* **youtube/spoof-signature-verification:** depend on `client-spoof` patch ([0d47375](ReVanced/revanced-patches@e826053))
* **youtubevanced/hide-ads:** hide more types of ads ([ReVanced#1781](ReVanced/revanced-patches#1781)) ([47ff447](ReVanced/revanced-patches@9a2430e))
* **youtubevanced/hide-ads:** remove broken ad filter ([ReVanced#1881](ReVanced/revanced-patches#1881)) ([5b987e1](ReVanced/revanced-patches@2835d1a))

### Features

* `change-package-name` patch ([ReVanced#1864](ReVanced/revanced-patches#1864)) ([f9a6672](ReVanced/revanced-patches@4bf3e77))
* `enable-android-debugging` patch ([ReVanced#1876](ReVanced/revanced-patches#1876)) ([bd224d9](ReVanced/revanced-patches@3dde507))
* **facebook:** `hide-inbox-ads` patch ([ReVanced#1893](ReVanced/revanced-patches#1893)) ([2cfc982](ReVanced/revanced-patches@a748510))
* **id-austria:** bump compatibility to `2.6.0` ([ReVanced#1827](ReVanced/revanced-patches#1827)) ([f48e794](ReVanced/revanced-patches@0dfd736))
* **inshorts:** `hide-ads` patch ([ReVanced#1828](ReVanced/revanced-patches#1828)) ([04a2acc](ReVanced/revanced-patches@a8c6031))
* **memegenerator:** `unlock-pro` patch ([ReVanced#1902](ReVanced/revanced-patches#1902)) ([7d30541](ReVanced/revanced-patches@003d0a1))
* **photomath/unlock-plus:** bump compatibility to `8.21.1` ([ReVanced#1926](ReVanced/revanced-patches#1926)) ([beb8d9c](ReVanced/revanced-patches@2b60efa))
* **photomath:** bump compatibility up to `8.21.0` ([ReVanced#1886](ReVanced/revanced-patches#1886)) ([43464fd](ReVanced/revanced-patches@fe58100))
* **reddit:** bump compatibility to `2023.12.0` ([ReVanced#1825](ReVanced/revanced-patches#1825)) ([e3666e6](ReVanced/revanced-patches@a003ec1))
* use better patch description ([32fcd25](ReVanced/revanced-patches@3de9938))
* **youtube-music:** `bypass-certificate-checks` patch ([ReVanced#1810](ReVanced/revanced-patches#1810)) ([ef8f26f](ReVanced/revanced-patches@7d7336d))
* **youtube/settings:** disable preferences and add dialog messages to preferences ([ReVanced#1801](ReVanced/revanced-patches#1801)) ([05023ba](ReVanced/revanced-patches@94261ce))
* **youtube/sponsorblock:** skip to video highlight ([ReVanced#1874](ReVanced/revanced-patches#1874)) ([83747b7](ReVanced/revanced-patches@96bdc2e))
* **youtube:** bump compatibility to `18.08.37` ([29561ec](ReVanced/revanced-patches@45f96a6))
* **youtube:** change default video speed and quality inside the settings menu ([ReVanced#1880](ReVanced/revanced-patches#1880)) ([fbb1763](ReVanced/revanced-patches@12c2fd5))
* **youtube:** constrain compatibility to `18.08.37` ([7403fc8](ReVanced/revanced-patches@cdee745))
* **youtube:** sponsorblock improvements ([ReVanced#1557](ReVanced/revanced-patches#1557)) ([b5d712a](ReVanced/revanced-patches@5e0ffbd))
* **youtube:** support version `18.08.37` ([4f4ceab](ReVanced/revanced-patches@fed3fe1))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.169.0 [skip ci]
90e5ba0 
# [2.169.0](ReVanced/revanced-patches@v2.168.0...v2.169.0) (2023-04-21)

### Bug Fixes

* add missing annotation to patches ([ReVanced#1882](ReVanced/revanced-patches#1882)) ([d86b6a4](ReVanced/revanced-patches@b6a7640))
* **youtube/hide-video-action-buttons:** change 'Hide create, clip and thanks buttons' to default off ([ReVanced#1923](ReVanced/revanced-patches#1923)) ([fc89c86](ReVanced/revanced-patches@f007c5e))
* **youtube/hide-video-action-buttons:** fix 'hide share button' ([ReVanced#1924](ReVanced/revanced-patches#1924)) ([bc05e44](ReVanced/revanced-patches@7f518de))
* **youtube/microg-support:** remove incorrect patch dependency ([3e0c45c](ReVanced/revanced-patches@2ec08b3))
* **youtube/microg-support:** rename patch correctly ([091a25d](ReVanced/revanced-patches@3b726f3))
* **youtube/return-youtube-dislike:** render dislikes when scrolling into the screen ([ReVanced#1873](ReVanced/revanced-patches#1873)) ([85675b8](ReVanced/revanced-patches@d9dc58d))
* **youtube/sponsorblock:** do not depend on `remember-playback-speed` patch ([b0834fa](ReVanced/revanced-patches@cbbd6bb))
* **youtube/sponsorblock:** fix autorepeat button layout ([ReVanced#1868](ReVanced/revanced-patches#1868)) ([5e148d9](ReVanced/revanced-patches@ddee5f0))
* **youtube/spoof-signature-verification:** depend on `client-spoof` patch ([0d47375](ReVanced/revanced-patches@e826053))
* **youtubevanced/hide-ads:** hide more types of ads ([ReVanced#1781](ReVanced/revanced-patches#1781)) ([47ff447](ReVanced/revanced-patches@9a2430e))
* **youtubevanced/hide-ads:** remove broken ad filter ([ReVanced#1881](ReVanced/revanced-patches#1881)) ([5b987e1](ReVanced/revanced-patches@2835d1a))

### Features

* `change-package-name` patch ([ReVanced#1864](ReVanced/revanced-patches#1864)) ([f9a6672](ReVanced/revanced-patches@4bf3e77))
* `enable-android-debugging` patch ([ReVanced#1876](ReVanced/revanced-patches#1876)) ([bd224d9](ReVanced/revanced-patches@3dde507))
* **facebook:** `hide-inbox-ads` patch ([ReVanced#1893](ReVanced/revanced-patches#1893)) ([2cfc982](ReVanced/revanced-patches@a748510))
* **id-austria:** bump compatibility to `2.6.0` ([ReVanced#1827](ReVanced/revanced-patches#1827)) ([f48e794](ReVanced/revanced-patches@0dfd736))
* **inshorts:** `hide-ads` patch ([ReVanced#1828](ReVanced/revanced-patches#1828)) ([04a2acc](ReVanced/revanced-patches@a8c6031))
* **memegenerator:** `unlock-pro` patch ([ReVanced#1902](ReVanced/revanced-patches#1902)) ([7d30541](ReVanced/revanced-patches@003d0a1))
* **photomath/unlock-plus:** bump compatibility to `8.21.1` ([ReVanced#1926](ReVanced/revanced-patches#1926)) ([beb8d9c](ReVanced/revanced-patches@2b60efa))
* **photomath:** bump compatibility up to `8.21.0` ([ReVanced#1886](ReVanced/revanced-patches#1886)) ([43464fd](ReVanced/revanced-patches@fe58100))
* **reddit:** bump compatibility to `2023.12.0` ([ReVanced#1825](ReVanced/revanced-patches#1825)) ([e3666e6](ReVanced/revanced-patches@a003ec1))
* use better patch description ([32fcd25](ReVanced/revanced-patches@3de9938))
* **youtube-music:** `bypass-certificate-checks` patch ([ReVanced#1810](ReVanced/revanced-patches#1810)) ([ef8f26f](ReVanced/revanced-patches@7d7336d))
* **youtube/settings:** disable preferences and add dialog messages to preferences ([ReVanced#1801](ReVanced/revanced-patches#1801)) ([05023ba](ReVanced/revanced-patches@94261ce))
* **youtube/sponsorblock:** skip to video highlight ([ReVanced#1874](ReVanced/revanced-patches#1874)) ([83747b7](ReVanced/revanced-patches@96bdc2e))
* **youtube:** bump compatibility to `18.08.37` ([29561ec](ReVanced/revanced-patches@45f96a6))
* **youtube:** change default video speed and quality inside the settings menu ([ReVanced#1880](ReVanced/revanced-patches#1880)) ([fbb1763](ReVanced/revanced-patches@12c2fd5))
* **youtube:** constrain compatibility to `18.08.37` ([7403fc8](ReVanced/revanced-patches@cdee745))
* **youtube:** sponsorblock improvements ([ReVanced#1557](ReVanced/revanced-patches#1557)) ([b5d712a](ReVanced/revanced-patches@5e0ffbd))
* **youtube:** support version `18.08.37` ([4f4ceab](ReVanced/revanced-patches@fed3fe1))
@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Crescendo-BLYAT @oSumAtrIX @SodaWithoutSparkles @anil-al @AMSAMSAMSAMS @LisoUseInAIKyrios