-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (YT) : Premium Header + Wide Search Bar appearing simultaneously. #2438
Comments
The wide search bar has a functional purpose unlike the header. Chose either |
# [2.178.0-dev.2](ReVanced/revanced-patches@v2.178.0-dev.1...v2.178.0-dev.2) (2023-06-16) ### Bug Fixes * **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@939661e))
# [2.178.0](ReVanced/revanced-patches@v2.177.0...v2.178.0) (2023-06-21) ### Bug Fixes * **boostforreddit:** use correct options ([ec39732](ReVanced/revanced-patches@97930d5)) * don't include all Litho patches, when not included ([fc69491](ReVanced/revanced-patches@74caba4)) * **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@939661e)) * **youtube/comments:** add missing filter ([ReVanced#2423](ReVanced/revanced-patches#2423)) ([cab04b3](ReVanced/revanced-patches@db8843d)) * **youtube/hide-album-cards:** call correct integrations method ([0dbffaa](ReVanced/revanced-patches@2698cc4)) * **youtube:** separate `hide-ads` to `hide-layout-components` patch ([7e0417f](ReVanced/revanced-patches@81f49c2)) ### Features * **boostforreddit:** add `change-oauth-client-id` patch ([3dbc4bd](ReVanced/revanced-patches@aaf63ef)) * **google-recorder:** add `remove-device-restrictions` patch ([ef96ed1](ReVanced/revanced-patches@e3590f4)) * **twitch:** 15.4.1 support ([ReVanced#2462](ReVanced/revanced-patches#2462)) ([826ed49](ReVanced/revanced-patches@2d47db0)) * **youtube-music:** remove version compatibility constraints ([276af14](ReVanced/revanced-patches@c0b609a)) * **youtube/hide-layout-components:** separate hiding expandable chips and chapters ([3fb1ce9](ReVanced/revanced-patches@d134804))
# [2.178.0-dev.2](ReVanced/revanced-patches@v2.178.0-dev.1...v2.178.0-dev.2) (2023-06-16) ### Bug Fixes * **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@d5efe26))
# [2.178.0](ReVanced/revanced-patches@v2.177.0...v2.178.0) (2023-06-21) ### Bug Fixes * **boostforreddit:** use correct options ([ec39732](ReVanced/revanced-patches@ec39732)) * don't include all Litho patches, when not included ([fc69491](ReVanced/revanced-patches@fc69491)) * **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@d5efe26)) * **youtube/comments:** add missing filter ([ReVanced#2423](ReVanced/revanced-patches#2423)) ([cab04b3](ReVanced/revanced-patches@cab04b3)) * **youtube/hide-album-cards:** call correct integrations method ([0dbffaa](ReVanced/revanced-patches@0dbffaa)) * **youtube:** separate `hide-ads` to `hide-layout-components` patch ([7e0417f](ReVanced/revanced-patches@7e0417f)) ### Features * **boostforreddit:** add `change-oauth-client-id` patch ([3dbc4bd](ReVanced/revanced-patches@3dbc4bd)) * **google-recorder:** add `remove-device-restrictions` patch ([ef96ed1](ReVanced/revanced-patches@ef96ed1)) * **twitch:** 15.4.1 support ([ReVanced#2462](ReVanced/revanced-patches#2462)) ([826ed49](ReVanced/revanced-patches@826ed49)) * **youtube-music:** remove version compatibility constraints ([276af14](ReVanced/revanced-patches@276af14)) * **youtube/hide-layout-components:** separate hiding expandable chips and chapters ([3fb1ce9](ReVanced/revanced-patches@3fb1ce9))
Still doesn't explain why cosmetic features & functional features cannot exist side-by-side. There's no rule like that in ReVanced docs. Waiting for member's reply. |
They can, its simply not worth the effort. Feel free to implement the patch and pull request it |
Feature description
It is requested please add a feature where "Premium Header" and "Wide Search Bar" appear simultaneously side-by-side.
![Screenshot_2023-12-15-09-13-11-09_f22faf49515899f9781ec174a4d85388](https://private-user-images.githubusercontent.com/91815107/290719231-4cef129d-9ad1-4c30-9a3b-eaa7ffeff690.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTA5NjQsIm5iZiI6MTcyMTUxMDY2NCwicGF0aCI6Ii85MTgxNTEwNy8yOTA3MTkyMzEtNGNlZjEyOWQtOWFkMS00YzMwLTlhM2ItZWFhN2ZmZWZmNjkwLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIxMjQyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ0MzMwZTA0YTg4OGQwNDlhYzIyMzM0ZDMyMmEyODEzYjc3ZWRmNDRmNDdjMDYwMjFlNDMwZDc0Njk5OWQ5MDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zeK7wzwzwZ174svBWre4Hv6K23Hyu2ZjhrFK1t6wFuw)
![Screenshot_2023-12-15-09-14-57-69_f22faf49515899f9781ec174a4d85388](https://private-user-images.githubusercontent.com/91815107/290719259-e37e397f-985b-4bb7-beea-8e60f6d8cbf2.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTA5NjQsIm5iZiI6MTcyMTUxMDY2NCwicGF0aCI6Ii85MTgxNTEwNy8yOTA3MTkyNTktZTM3ZTM5N2YtOTg1Yi00YmI3LWJlZWEtOGU2MGY2ZDhjYmYyLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIxMjQyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkY2QzYmE4NzJhZDU3NTc0ZTI2ODI3MmNlYzQ1Mzc1OWU5MDViYzQ2ZmNiMjRhZjEwZjQ5YmZlNjhkNjQ0MDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QuVLNY2qmPsEbdb1VJD95MVQx7MbxsKjxj4cdWYbcDs)
Motivation
1.) After the introduction of You tab, space has increased on the top header. So, both Premium Header & Wide Search bar can be occupied.
2.) Search button is a basic feature, so it should have a bigger bar without compromising on the Premium Header.
Thank you.
Acknowledgements
The text was updated successfully, but these errors were encountered: