Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: patched Strava app on current recommend version blocks signing in #2516

Closed
3 tasks done
Habylab opened this issue Dec 19, 2023 · 6 comments
Closed
3 tasks done

bug: patched Strava app on current recommend version blocks signing in #2516

Habylab opened this issue Dec 19, 2023 · 6 comments
Labels
Bug report Something isn't working

Comments

@Habylab
Copy link

Habylab commented Dec 19, 2023

Bug description

After patching the latest recommended version of Strava, on a clean install, the app won't login. This is via both Google login and username password. It just doesn't work.

Installing that older version without patching works fine. Must be something to do with the patches themselves.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Habylab Habylab added the Bug report Something isn't working label Dec 19, 2023
@oSumAtrIX
Copy link
Member

What is the last version working?

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Dec 19, 2023
@LisoUseInAIKyrios
Copy link
Contributor

@Habylab is it working with 320.12? The patches only support that exact version.

@Habylab
Copy link
Author

Habylab commented Dec 20, 2023 via email

@LisoUseInAIKyrios
Copy link
Contributor

If patching a version outside of 320.12 then the expected outcome is failure.

If the patches are working with 320.12 then there is no bug here. Reopen if this is not the case.

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Dec 20, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.179.0-dev.6 [skip ci]
438b1a1 
# [2.179.0-dev.6](ReVanced/revanced-patches@v2.179.0-dev.5...v2.179.0-dev.6) (2023-06-27)

### Bug Fixes

* **syncforreddit/change-oauth-client-id:** add dev edition ([ReVanced#2516](ReVanced/revanced-patches#2516)) ([7c7294b](ReVanced/revanced-patches@d6a5821))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.179.0 [skip ci]
8ce05a0 
# [2.179.0](ReVanced/revanced-patches@v2.178.0...v2.179.0) (2023-07-01)

### Bug Fixes

* **enable-android-debugging:** remove json options ([ReVanced#2497](ReVanced/revanced-patches#2497)) ([3e25f5f](ReVanced/revanced-patches@6fbdd5a))
* **relayforreddit/change-oauth-client-id:** change client id instead of developer key ([ReVanced#2508](ReVanced/revanced-patches#2508)) ([4befb44](ReVanced/revanced-patches@5ee685b))
* **syncforreddit/change-oauth-client-id:** add dev edition ([ReVanced#2516](ReVanced/revanced-patches#2516)) ([7c7294b](ReVanced/revanced-patches@d6a5821))
* **syncforreddit:** use correct overriding method signature ([ReVanced#2483](ReVanced/revanced-patches#2483)) ([f9770cf](ReVanced/revanced-patches@112d09e))
* **youtube/client-spoof:** update settings text for known side effects of spoof signature ([ReVanced#2476](ReVanced/revanced-patches#2476)) ([6756f80](ReVanced/revanced-patches@1374deb))
* **youtube:** improve patching speed ([ReVanced#2514](ReVanced/revanced-patches#2514)) ([77bb761](ReVanced/revanced-patches@40ab70a))

### Features

* **baconreader:** add `change-oauth-client-id` patch ([ReVanced#2535](ReVanced/revanced-patches#2535)) ([6f5e007](ReVanced/revanced-patches@943cca0))
* **infinityforreddit:** add `change-oauth-client-id` patch ([ReVanced#2452](ReVanced/revanced-patches#2452)) ([9efd790](ReVanced/revanced-patches@fadf462))
* **reddit:** add `disable-screenshot-popup` patch ([ReVanced#2387](ReVanced/revanced-patches#2387)) ([473e051](ReVanced/revanced-patches@473d7f5))
* **redditisfun/change-oauth-client-id:** add compatibility for paid versions ([ReVanced#2536](ReVanced/revanced-patches#2536)) ([e739d2f](ReVanced/revanced-patches@4a48bfd))
* **redditisfun:** add `change-oauth-client-id` patch ([14809cd](ReVanced/revanced-patches@1d1432f))
* **relayforreddit:** add `change-oauth-client-id` patch ([ReVanced#2491](ReVanced/revanced-patches#2491)) ([fe66f40](ReVanced/revanced-patches@54721b1))
@Dan-Crook
Copy link

This bug is still occurring for me.
Using strava version 320.12 which is the reccomended version for patching.
Login works when not patched but does not work when patched.
Using email, face book or Google login.

@oSumAtrIX
Copy link
Member

Open a new issue

tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.179.0-dev.6 [skip ci]
eb69a88 
# [2.179.0-dev.6](ReVanced/revanced-patches@v2.179.0-dev.5...v2.179.0-dev.6) (2023-06-27)

### Bug Fixes

* **syncforreddit/change-oauth-client-id:** add dev edition ([ReVanced#2516](ReVanced/revanced-patches#2516)) ([7c7294b](ReVanced/revanced-patches@7c7294b))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.179.0 [skip ci]
a7c18ca 
# [2.179.0](ReVanced/revanced-patches@v2.178.0...v2.179.0) (2023-07-01)

### Bug Fixes

* **enable-android-debugging:** remove json options ([ReVanced#2497](ReVanced/revanced-patches#2497)) ([3e25f5f](ReVanced/revanced-patches@3e25f5f))
* **relayforreddit/change-oauth-client-id:** change client id instead of developer key ([ReVanced#2508](ReVanced/revanced-patches#2508)) ([4befb44](ReVanced/revanced-patches@4befb44))
* **syncforreddit/change-oauth-client-id:** add dev edition ([ReVanced#2516](ReVanced/revanced-patches#2516)) ([7c7294b](ReVanced/revanced-patches@7c7294b))
* **syncforreddit:** use correct overriding method signature ([ReVanced#2483](ReVanced/revanced-patches#2483)) ([f9770cf](ReVanced/revanced-patches@f9770cf))
* **youtube/client-spoof:** update settings text for known side effects of spoof signature ([ReVanced#2476](ReVanced/revanced-patches#2476)) ([6756f80](ReVanced/revanced-patches@6756f80))
* **youtube:** improve patching speed ([ReVanced#2514](ReVanced/revanced-patches#2514)) ([77bb761](ReVanced/revanced-patches@77bb761))

### Features

* **baconreader:** add `change-oauth-client-id` patch ([ReVanced#2535](ReVanced/revanced-patches#2535)) ([6f5e007](ReVanced/revanced-patches@6f5e007))
* **infinityforreddit:** add `change-oauth-client-id` patch ([ReVanced#2452](ReVanced/revanced-patches#2452)) ([9efd790](ReVanced/revanced-patches@9efd790))
* **reddit:** add `disable-screenshot-popup` patch ([ReVanced#2387](ReVanced/revanced-patches#2387)) ([473e051](ReVanced/revanced-patches@473e051))
* **redditisfun/change-oauth-client-id:** add compatibility for paid versions ([ReVanced#2536](ReVanced/revanced-patches#2536)) ([e739d2f](ReVanced/revanced-patches@e739d2f))
* **redditisfun:** add `change-oauth-client-id` patch ([14809cd](ReVanced/revanced-patches@14809cd))
* **relayforreddit:** add `change-oauth-client-id` patch ([ReVanced#2491](ReVanced/revanced-patches#2491)) ([fe66f40](ReVanced/revanced-patches@fe66f40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Habylab @oSumAtrIX @LisoUseInAIKyrios @Dan-Crook