Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update queries test #58

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Update queries test #58

merged 3 commits into from
Apr 21, 2017

Conversation

VinSpee
Copy link
Contributor

@VinSpee VinSpee commented Apr 20, 2017

update test / readme to cover use of queries on attributes as mentioned in #38.

@VinSpee
Copy link
Contributor Author

VinSpee commented Apr 20, 2017

Gah didn't realize we're not transpiling tests. update coming

@mjackson
Copy link
Member

Our tests do run through babel but we don't include the babel-polyfill which I think you'd probably need for the Array.from to work.

@VinSpee
Copy link
Contributor Author

VinSpee commented Apr 20, 2017

No problem, easy enough to just use the classList.contains method. Thanks!

@mjackson mjackson merged commit 193c01c into ReactTraining:master Apr 21, 2017
@mjackson
Copy link
Member

Thanks again, @VinSpee

@nezed nezed mentioned this pull request Jun 21, 2017
Closed
@nezed nezed mentioned this pull request Jul 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VinSpee @mjackson