-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Provide production-ready versions of CJS and ESM builds - Deprecate requiring individual files, e.g. require('react-router/Route') - Remove dependency on babel-plugin-transform-imports Fixes #6387
- Loading branch information
Showing
102 changed files
with
938 additions
and
606 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
es/ | ||
cjs/ | ||
esm/ | ||
umd/ | ||
/*.js | ||
!/rollup.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("matchRoutes"); | ||
|
||
import { matchRoutes } from "../esm/react-router-config.js"; | ||
export default matchRoutes; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("renderRoutes"); | ||
|
||
import { renderRoutes } from "../esm/react-router-config.js"; | ||
export default renderRoutes; |
35 changes: 35 additions & 0 deletions
35
packages/react-router-config/es/warnAboutDeprecatedESMImport.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
"use strict"; | ||
|
||
var printWarning = function() {}; | ||
|
||
if (process.env.NODE_ENV !== "production") { | ||
printWarning = function(format, subs) { | ||
var index = 0; | ||
var message = | ||
"Warning: " + | ||
(subs.length > 0 | ||
? format.replace(/%s/g, function() { | ||
return subs[index++]; | ||
}) | ||
: format); | ||
|
||
if (typeof console !== "undefined") { | ||
console.error(message); | ||
} | ||
|
||
try { | ||
// --- Welcome to debugging React Router --- | ||
// This error was thrown as a convenience so that you can use the | ||
// stack trace to find the callsite that triggered this warning. | ||
throw new Error(message); | ||
} catch (e) {} | ||
}; | ||
} | ||
|
||
export default function(member) { | ||
printWarning( | ||
'Please use `import { %s } from "react-router-config"` instead of `import %s from "react-router-config/%s"`. ' + | ||
"Support for the latter will be removed in the next major release.", | ||
[member, member] | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
if (process.env.NODE_ENV === "production") { | ||
module.exports = require("./cjs/react-router-config.min.js"); | ||
} else { | ||
module.exports = require("./cjs/react-router-config.js"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire.js")("matchRoutes"); | ||
module.exports = require("./index.js").matchRoutes; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire.js")("renderRoutes"); | ||
module.exports = require("./index.js").renderRoutes; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
packages/react-router-config/warnAboutDeprecatedCJSRequire.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
"use strict"; | ||
|
||
var printWarning = function() {}; | ||
|
||
if (process.env.NODE_ENV !== "production") { | ||
printWarning = function(format, subs) { | ||
var index = 0; | ||
var message = | ||
"Warning: " + | ||
(subs.length > 0 | ||
? format.replace(/%s/g, function() { | ||
return subs[index++]; | ||
}) | ||
: format); | ||
|
||
if (typeof console !== "undefined") { | ||
console.error(message); | ||
} | ||
|
||
try { | ||
// --- Welcome to debugging React Router --- | ||
// This error was thrown as a convenience so that you can use the | ||
// stack trace to find the callsite that triggered this warning. | ||
throw new Error(message); | ||
} catch (e) {} | ||
}; | ||
} | ||
|
||
module.exports = function(member) { | ||
printWarning( | ||
'Please use `require("react-router-config").%s` instead of `require("react-router-config/%s")`. ' + | ||
"Support for the latter will be removed in the next major release.", | ||
[member, member] | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
es/ | ||
cjs/ | ||
esm/ | ||
umd/ | ||
/*.js | ||
!/rollup.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("BrowserRouter"); | ||
module.exports = require("./index.js").BrowserRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("HashRouter"); | ||
module.exports = require("./index.js").HashRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Link"); | ||
module.exports = require("./index.js").Link; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("MemoryRouter"); | ||
module.exports = require("./index.js").MemoryRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("NavLink"); | ||
module.exports = require("./index.js").NavLink; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Prompt"); | ||
module.exports = require("./index.js").Prompt; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Redirect"); | ||
module.exports = require("./index.js").Redirect; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Route"); | ||
module.exports = require("./index.js").Route; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Router"); | ||
module.exports = require("./index.js").Router; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("StaticRouter"); | ||
module.exports = require("./index.js").StaticRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
require("./warnAboutDeprecatedCJSRequire")("Switch"); | ||
module.exports = require("./index.js").Switch; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("BrowserRouter"); | ||
|
||
import { BrowserRouter } from "../esm/react-router-dom.js"; | ||
export default BrowserRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("HashRouter"); | ||
|
||
import { HashRouter } from "../esm/react-router-dom.js"; | ||
export default HashRouter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("Link"); | ||
|
||
import { Link } from "../esm/react-router-dom.js"; | ||
export default Link; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
"use strict"; | ||
|
||
import warnAboutDeprecatedESMImport from "./warnAboutDeprecatedESMImport.js"; | ||
warnAboutDeprecatedESMImport("MemoryRouter"); | ||
|
||
import { MemoryRouter } from "../esm/react-router-dom.js"; | ||
export default MemoryRouter; |
Oops, something went wrong.
5bde02b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjackson I think you just broke everybody's build.
esm/index.js
doesn't exist. At least I don't see what generates it.Can we go with old school way and just leave
NODE_ENV
replacing for user? This will allow to have such beautiful disthttps://unpkg.com/react-beautiful-dnd@9.0.2/dist/
5bde02b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way you also bundled prop types which is bad for users bundles. If you want I can simplify the build step a bit.
5bde02b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrySound Ah yes, I was trying to figure out what else I could point to besides
esm/index.js
. I guess we just point it at the development build for now? And yes, I would love some help cleaning up and simplifying the build. I know you've done a ton of work on this for React itself.5bde02b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrySound Let's discuss in #6393