Fix handling of patterns that are method names #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,4 +41,8 @@ describe('matchPattern', function () { | |||
| assertMatch('/**/*.jpg', '/files/path/to/file.jpg', '', [ 'splat', 'splat' ], [ 'files/path/to', 'file' ]) | |||
| }) | |||
|
|
|||
| it('works with patterns that match built-in names', function () { | |||
There was a problem hiding this comment.
This test case passes against master, but worth asserting here anyway.
There was a problem hiding this comment.
Can you get it to fail against Firefox with 'watch'?
There was a problem hiding this comment.
Not here – matchPattern prepends a / to all patterns to match the pathname.
The failing test case is the getParamsName one, which currently would fail on all browsers.
|
Rebased |
1 task
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3679.
Includes #3678 (needed for CI to pass).
PatternUtilsis sort of a mess, incidentally. There's no reason to exportcompilePattern, and there's no real reason thatgetParamsshould still exist (nothing calls it). I also don't know whygetRouteParamsis completely separate module, either.I want to fix/deprecate, but it's not that compelling right now.