Re-enable Shared tests for the Universal build #840

pre10der89 · 2016-10-28T23:32:37Z

Enable shared tests for universal build.

…... Any TestFixtures that utilize the NMock3 library need to be isolated in the .NET test project(s)... Moved NMock3 related tests from ReactiveNative.Shared.Tests to ReactNative46.Tests. The majority of tests in JavaScriptModuleBaseTests.cs utilized NMock so the entire file was moved from the ReactiveNative.Shared.Tests to the ReactNative.Net46.Tests projects. A handful of tests in JavaScriptModuleRegistryTests.cs utilized NMock. A specialized class inheriting from JavaScriptModuleRegistryTests was added to the ReactNative.Net46.Tests project. The specialized class "JavaScriptModuleRegistryNMockTests" contains only the NMock dependent tests and the base class contains all tests that can be shared. All references to NMock have been removed from the test code in the ReactNative.Shared.Tests projects... A reference to the ReactNative.Shared.Tests has been added to the ReactNative.Tests project. Additionally, the NUnit v3.41 nuGet package and the NUnit3TestAdapter v 3.5 nuGet package were added to the ReactNative.Tests project. The NUnit3TestAdapter v 3.41 nuGet package could not be loaded in the ReactNative.Tests project so v3.5 (the latest) was used. This creates a version mismatch with the NUnit package and the nuGet packages used in the ReactNative.Net46.Tests project...

…indows into nmock-net46

…t is already included in ReactNative.Shared.Tests

…egistryNMockTests.cs" to match the class name...

…lass name...

matthargett

Need to upgrade NUnit nuget references in ReactNative.Net46.Tests project to also be NUnit 3.5.0.

I verified ReactNative.Tests does indeed include the Shared tests, but VS2015 Test Explorer doesn't show two separate tests with the same name as being separate unless you choose 'group by project' in the drop down in the top left of the VS2015 Test Explorer.

I tried various ways to get before-and-after code coverage on Universal tests, but after 5 different tools and much trial and error, I gave up. Maybe code coverage works in Visual Studio Enterprise edition, but I don't have access to that right now. I was able to verify coverage on Net46.Tests didn't go down.

I also found a few bugs in ReSharper's test runner, not the fault of this commit, which I filed with JetBrains.

rozele · 2016-10-31T14:20:31Z

��<�!�D�O�C�T�Y�P�E� �h�t�m�l�>�

This file shouldn't be added (we may want to add it to the .gitignore while we're at it)

Refers to: ReactWindows/UpgradeLog.htm:1 in 53461be. [](commit_id = 53461be, deletion_comment = False)

rozele · 2016-10-31T14:21:47Z

So have the JavaScriptModuleBaseTests been lost from UWP? #Closed

Refers to: ReactWindows/ReactNative.Tests/ReactNative.Tests.csproj:97 in 53461be. [](commit_id = 53461be, deletion_comment = False)

rozele · 2016-10-31T14:22:26Z

ReactWindows/ReactNative.Tests/Internal/MockJavaScriptExecutor.cs

-
-namespace ReactNative.Tests
-{
-    class MockJavaScriptExecutor : IJavaScriptExecutor


MockJavaScriptExecutor [](start = 10, length = 22)

You may have to leave this if you are going to bring back the JavaScriptModuleBaseTests that were available to UWP before. #Closed

MockJavaScriptExecutor comes in from Shared.Tests now. We had made a copy of it in Shared.Tests in an earlier PR leading up to this. A few other fixtures use that static mock as well. #Closed

…also be NUnit 3.5.0. NUnit upgraded to 3.5.0 NUnit3TestRunner upgraded to 3.5.1

…indows into nmock-net46

…-windows into nmock-net46

…-windows

…indows into nmock-net46

matthargett · 2016-10-31T22:45:01Z

(I can't reply to the specific comment, for some reason.) Some tests in JavaScriptModuleBaseTests use NMock instead of the hand-rolled mocks there previously, so they're now in Net46. I think it would be a good idea to extract a base class into Shared.Tests and sub-class it in Net46 to add the complex interaction tests there. If we want to back-fill the hand-rolled mocks to improve coverage in Universal tests, we can do that in a subclass in that project. What do you think of that @rozele ?

…-windows

rozele · 2016-11-01T15:54:57Z

appveyor.yml

+
+    npm install -g react-native-cli
+
+    npm install


This step will take a while.

We can get rid of it, but caching node_modules with AppVeyor brings it down. Happy to ditch it for now.

Let's ditch it until we have something like Appium in place.

In reply to: 85961643 [](ancestors = 85961643)

What if we did Yarn? It does system caching automatically.

rozele · 2016-11-01T15:55:24Z

appveyor.yml

+
+    mkdir ReactWindows\Playground\ReactAssets
+
+    react-native bundle --platform windows --entry-file ReactWindows/Playground/index.windows.js --bundle-output ReactWindows/Playground/ReactAssets/index.windows.bundle --assets-dest ReactWindows/Playground/ReactAssets/


Why do we need to test this? The bundle command comes exclusively from facebook/react-native

I had it in my build for two reasons:

To make sure upstream republishes with same version didn't become incompatible with the Playground index.*.js

To have Playground ReleaseBundle artefacts at the end of the build that were ready to run for basic UI tests that would verify the "Welcome to React Native" message (versus a redbox, which would be a regression).

Happy to ditch the step for the main repo build.

Let's only add this back once we actually have an Appium step. All this is doing for now is building the bundle, which is pretty fail safe (it won't catch most of the issues that we'd actually care about for regressions that we could only see by running an app using the bundle)

In reply to: 85962148 [](ancestors = 85962148)

Unfortunately, JavaScript is not compiled, and the bundler only picks up very specific "compile-like" issues like missing modules

In reply to: 85981159 [](ancestors = 85981159,85962148)

rozele · 2016-11-01T15:56:12Z

ReactWindows/ReactNative.Shared.Tests/Bridge/JavaScriptModuleRegistryTests.cs

-        }
-
-        [Test]
-        public void InvokesReactInstanceWhenFetchedModuleIsCalled()


InvokesReactInstanceWhenFetchedModuleIsCalled [](start = 20, length = 45)

I presume a duplicate of this is left in ReactNative.Tests? #Closed

No, but we can fix that. Can you fix and push @pre10der89 ? #Closed

My latest push adds the InvokesReactInstanceWhenFetchedModuleIsCalled and ThrowsWhenUnkonwModuleRequested to the ReactNative.Tests using the implementations that existed before they were converted to NMock... #Closed

…indows into nmock-net46

rozele · 2016-11-01T17:36:06Z

Seems weird to have base classes for unit test classes.

In reply to: 257442508 [](ancestors = 257442508)

…-windows

…indows into nmock-net46

…and the containing class from JavascriptModuleRegistryTests to JavascriptModuleRegistrySharedTests. * ReactNative.Net46.Tests: Renamed JavascriptModuleRegistryNMockTests.cs and the containing class from JavascriptModuleRegistryNMockTests to JavascriptModuleRegistryTests. Changed the base class to JavascriptModuleRegistrySharedTests. * ReactNative.Tests: Added JavascriptModuleRegistryTests.cs to project that uses Univesal-specific mocking in place of NMock. Inherited containing class from JavascriptModuleRegistrySharedTests.

…ecific tests in JavaScriptModuleRegistryTests

matthargett · 2016-11-02T01:40:48Z

Couple of different texts for the test base class pattern: Test Driven Development, A Practical Guide; Extreme Programming Adventures in C#; Test-Driven Development in Microsoft .NET; Pragmatic Unit Testing in C#. Even in some of the React projects I've worked on, an inheritance pattern is used in Selenium-based Jasmine tests when mixins aren't appropriate.

…onents from the AppVeyor config

rozele · 2016-11-02T17:14:25Z

appveyor.yml

+    %DEVENV% /build "Debug|x64" ReactWindows\ReactNative.sln
+
+    npm install -g npm
+


rozele · 2016-11-02T17:14:33Z

appveyor.yml

+    npm install -g npm
+
+    npm version
+


rozele · 2016-11-02T17:15:02Z

appveyor.yml

+    set DEVENV="%VS140COMNTOOLS%\..\IDE\devenv"
+
+    %DEVENV% /build "Debug|x64" ReactWindows\ReactNative.sln
+


I thought we were going to do Debug builds for all platforms, release for just x64.

rozele · 2016-11-02T17:15:58Z

appveyor.yml

+
+    npm version
+
+    %DEVENV% /build "ReleaseBundle|x64" ReactWindows\ReactNative.sln


ReleaseBundle [](start = 21, length = 13)

I don't think we really need to build the *Bundle configs for react-native-windows, basically because the Bundle part only comes in to play at the application level (ReleaseBundle just maps to Release and DebugBundle just maps to Debug)

There's a couple of #ifs in the code for bundle builds that I'd like to keep coverage on. We can do it for x86 Debug instead, perhaps?

rozele · 2016-11-02T17:16:45Z

It looks like there is a change to the pointer for the Examples branch. It might have been committed by mistake.

…-windows

…indows into nmock-net46

* The NMock3 library is not compatiable with Universal Windows Projects... Any TestFixtures that utilize the NMock3 library need to be isolated in the .NET test project(s)... Moved NMock3 related tests from ReactiveNative.Shared.Tests to ReactNative46.Tests. The majority of tests in JavaScriptModuleBaseTests.cs utilized NMock so the entire file was moved from the ReactiveNative.Shared.Tests to the ReactNative.Net46.Tests projects. A handful of tests in JavaScriptModuleRegistryTests.cs utilized NMock. A specialized class inheriting from JavaScriptModuleRegistryTests was added to the ReactNative.Net46.Tests project. The specialized class "JavaScriptModuleRegistryNMockTests" contains only the NMock dependent tests and the base class contains all tests that can be shared. All references to NMock have been removed from the test code in the ReactNative.Shared.Tests projects... A reference to the ReactNative.Shared.Tests has been added to the ReactNative.Tests project. Additionally, the NUnit v3.41 nuGet package and the NUnit3TestAdapter v 3.5 nuGet package were added to the ReactNative.Tests project. The NUnit3TestAdapter v 3.41 nuGet package could not be loaded in the ReactNative.Tests project so v3.5 (the latest) was used. This creates a version mismatch with the NUnit package and the nuGet packages used in the ReactNative.Net46.Tests project... * The NMock3 library is not compatiable with Universal Windows Projects... Any TestFixtures that utilize the NMock3 library need to be isolated in the .NET test project(s)... Moved NMock3 related tests from ReactiveNative.Shared.Tests to ReactNative46.Tests. The majority of tests in JavaScriptModuleBaseTests.cs utilized NMock so the entire file was moved from the ReactiveNative.Shared.Tests to the ReactNative.Net46.Tests projects. A handful of tests in JavaScriptModuleRegistryTests.cs utilized NMock. A specialized class inheriting from JavaScriptModuleRegistryTests was added to the ReactNative.Net46.Tests project. The specialized class "JavaScriptModuleRegistryNMockTests" contains only the NMock dependent tests and the base class contains all tests that can be shared. All references to NMock have been removed from the test code in the ReactNative.Shared.Tests projects... A reference to the ReactNative.Shared.Tests has been added to the ReactNative.Tests project. Additionally, the NUnit v3.41 nuGet package and the NUnit3TestAdapter v 3.5 nuGet package were added to the ReactNative.Tests project. The NUnit3TestAdapter v 3.41 nuGet package could not be loaded in the ReactNative.Tests project so v3.5 (the latest) was used. This creates a version mismatch with the NUnit package and the nuGet packages used in the ReactNative.Net46.Tests project... * Removing "MockJavaScriptExecutor.cs" from ReactNative.Tests because it is already included in ReactNative.Shared.Tests * Renaming "JavaScriptModuleRegistryMockTests.cs" to "JavaScriptModuleRegistryNMockTests.cs" to match the class name... * Renaming JavaScriptModuleRegistryMockTests.cs to match the included class name... * Upgrade NUnit version in ReactNative.Tests project * Upgrade NUnit nuget references in ReactNative.Net46.Tests project to also be NUnit 3.5.0. NUnit upgraded to 3.5.0 NUnit3TestRunner upgraded to 3.5.1 * Syncing with upstream * Removing UpgradeLog.htm; adding UpgradeLog.htm to .gitignore * Adding appveyor.yml * * ReactNative.Shared.Tests: Renamed JavascriptModuleRegistryTests.cs and the containing class from JavascriptModuleRegistryTests to JavascriptModuleRegistrySharedTests. * ReactNative.Net46.Tests: Renamed JavascriptModuleRegistryNMockTests.cs and the containing class from JavascriptModuleRegistryNMockTests to JavascriptModuleRegistryTests. Changed the base class to JavascriptModuleRegistrySharedTests. * ReactNative.Tests: Added JavascriptModuleRegistryTests.cs to project that uses Univesal-specific mocking in place of NMock. Inherited containing class from JavascriptModuleRegistrySharedTests. * Adding new and renamed files * Restoring the 0.27-stable branch implementations of some universal specific tests in JavaScriptModuleRegistryTests * Removing npm install -g react-native-cli and react-native bundle components from the AppVeyor config * Removing x86 and ARM builds and x86 tests from AppVeyor config * Reverting to previous examples version

pre10der89 added 7 commits October 27, 2016 09:39

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

807ecd5

…indows into nmock-net46

Removing "MockJavaScriptExecutor.cs" from ReactNative.Tests because i…

7c8cf1a

…t is already included in ReactNative.Shared.Tests

Renaming "JavaScriptModuleRegistryMockTests.cs" to "JavaScriptModuleR…

68c6d63

…egistryNMockTests.cs" to match the class name...

Renaming JavaScriptModuleRegistryMockTests.cs to match the included c…

5d6fb09

…lass name...

Upgrade NUnit version in ReactNative.Tests project

53461be

matthargett changed the title ~~Nmock net46~~ Re-enablle Shared tests for the Universal build Oct 29, 2016

matthargett changed the title ~~Re-enablle Shared tests for the Universal build~~ Re-enable Shared tests for the Universal build Oct 29, 2016

matthargett mentioned this pull request Oct 31, 2016

Move shared tests to shared #837

Closed

matthargett suggested changes Oct 31, 2016

View reviewed changes

rozele reviewed Oct 31, 2016

View reviewed changes

pre10der89 added 8 commits October 31, 2016 09:46

Upgrade NUnit nuget references in ReactNative.Net46.Tests project to …

47a1f76

…also be NUnit 3.5.0. NUnit upgraded to 3.5.0 NUnit3TestRunner upgraded to 3.5.1

Syncing with upstream

88370b1

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

3d15ca3

…indows into nmock-net46

Removing UpgradeLog.htm; adding UpgradeLog.htm to .gitignore

221fc3a

Adding appveyor.yml

7877e0c

Merge branch 'master' of https://github.com/ReactWindows/react-native…

152e903

…-windows into nmock-net46

Merge branch 'master' of https://github.com/ReactWindows/react-native…

f84414a

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

ad7cf59

…indows into nmock-net46

matthargett approved these changes Oct 31, 2016

View reviewed changes

pre10der89 added 2 commits October 31, 2016 16:29

Merge branch 'master' of https://github.com/ReactWindows/react-native…

03ced95

…-windows

Merge branch 'master' of https://github.com/ReactWindows/react-native…

06f707e

…-windows

rozele reviewed Nov 1, 2016

View reviewed changes

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

98c791b

…indows into nmock-net46

pre10der89 added 5 commits November 1, 2016 11:10

Merge branch 'master' of https://github.com/ReactWindows/react-native…

4a27072

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

08162df

…indows into nmock-net46

Adding new and renamed files

d50ae64

Restoring the 0.27-stable branch implementations of some universal sp…

8de4e29

…ecific tests in JavaScriptModuleRegistryTests

pre10der89 added 2 commits November 2, 2016 08:36

Removing npm install -g react-native-cli and react-native bundle comp…

b8bcc43

…onents from the AppVeyor config

Removing x86 and ARM builds and x86 tests from AppVeyor config

06f0a59

rozele reviewed Nov 2, 2016

View reviewed changes

appveyor.yml

%DEVENV% /build "Debug|x64" ReactWindows\ReactNative.sln

npm install -g npm

Copy link

Collaborator

rozele Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed?

rozele reviewed Nov 2, 2016

View reviewed changes

pre10der89 added 3 commits November 2, 2016 10:57

Merge branch 'master' of https://github.com/ReactWindows/react-native…

32a32a8

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

14117d9

…indows into nmock-net46

Reverting to previous examples version

16f8a7e

rozele merged commit fb20e5a into microsoft:master Nov 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable Shared tests for the Universal build #840

Re-enable Shared tests for the Universal build #840

pre10der89 commented Oct 28, 2016 •

edited

matthargett left a comment

rozele commented Oct 31, 2016

rozele commented Oct 31, 2016 •

edited

rozele Oct 31, 2016 •

edited

matthargett Oct 31, 2016 •

edited by rozele

matthargett commented Oct 31, 2016

rozele Nov 1, 2016

matthargett Nov 1, 2016

rozele Nov 1, 2016

kevinvangelder Nov 1, 2016

rozele Nov 1, 2016

matthargett Nov 1, 2016

rozele Nov 1, 2016

rozele Nov 1, 2016

rozele Nov 1, 2016 •

edited

matthargett Nov 1, 2016 •

edited by rozele

pre10der89 Nov 1, 2016 •

edited by rozele

rozele commented Nov 1, 2016

matthargett commented Nov 2, 2016

rozele Nov 2, 2016

rozele Nov 2, 2016

matthargett Nov 2, 2016

rozele Nov 2, 2016

rozele Nov 2, 2016

matthargett Nov 2, 2016

rozele commented Nov 2, 2016


		mkdir ReactWindows\Playground\ReactAssets

		react-native bundle --platform windows --entry-file ReactWindows/Playground/index.windows.js --bundle-output ReactWindows/Playground/ReactAssets/index.windows.bundle --assets-dest ReactWindows/Playground/ReactAssets/

		%DEVENV% /build "Debug\|x64" ReactWindows\ReactNative.sln

		npm install -g npm

		set DEVENV="%VS140COMNTOOLS%\..\IDE\devenv"

		%DEVENV% /build "Debug\|x64" ReactWindows\ReactNative.sln


		npm version

		%DEVENV% /build "ReleaseBundle\|x64" ReactWindows\ReactNative.sln

Re-enable Shared tests for the Universal build #840

Re-enable Shared tests for the Universal build #840

Conversation

pre10der89 commented Oct 28, 2016 • edited

matthargett left a comment

Choose a reason for hiding this comment

rozele commented Oct 31, 2016

rozele commented Oct 31, 2016 • edited

rozele Oct 31, 2016 • edited

Choose a reason for hiding this comment

matthargett Oct 31, 2016 • edited by rozele

Choose a reason for hiding this comment

matthargett commented Oct 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 1, 2016 • edited

Choose a reason for hiding this comment

matthargett Nov 1, 2016 • edited by rozele

Choose a reason for hiding this comment

pre10der89 Nov 1, 2016 • edited by rozele

Choose a reason for hiding this comment

rozele commented Nov 1, 2016

matthargett commented Nov 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele commented Nov 2, 2016

pre10der89 commented Oct 28, 2016 •

edited

rozele commented Oct 31, 2016 •

edited

rozele Oct 31, 2016 •

edited

matthargett Oct 31, 2016 •

edited by rozele

rozele Nov 1, 2016 •

edited

matthargett Nov 1, 2016 •

edited by rozele

pre10der89 Nov 1, 2016 •

edited by rozele